Repository navigation
Conversation
Calling a promisified function whose original returns a Promise is a likely mistake rather than use of a deprecated API, so DEP0174 is revoked and the DeprecationWarning is replaced with a regular process warning using the code PROMISIFY_RETURNED_PROMISE. The warning is now emitted once per promisified function rather than on every call, and can be silenced with --disable-warning=PROMISIFY_RETURNED_PROMISE. Rejections of the returned Promise are now forwarded to the promise returned by the promisified function instead of being left unhandled. If the callback has already settled the result, the rejection is rethrown so that it is still reported as an unhandled rejection rather than silently swallowed. Refs: nodejs#49609 Refs: nodejs#49647 Refs: nodejs#49607 Assisted-by: Claude Signed-off-by: James M Snell <jasnell@gmail.com>
Collaborator
|
Review requested:
|
jasnell
commented
Nov 15, 2026
jasnell
commented
Nov 15, 2026
Co-authored-by: James M Snell <jasnell@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67489 +/- ##
==========================================
- Coverage 90.67% 90.65% -0.02%
==========================================
Files 799 799
Lines 280245 280263 +18
Branches 54125 54120 -5
==========================================
- Hits 254100 254084 -16
- Misses 16280 16297 +17
- Partials 9865 9882 +17
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling a promisified function whose original returns a Promise is a likely mistake rather than use of a deprecated API, so DEP0174 is revoked and the DeprecationWarning is replaced with a regular process warning using the code PROMISIFY_RETURNED_PROMISE. The warning is now emitted once per promisified function rather than on every call, and can be silenced with --disable-warning=PROMISIFY_RETURNED_PROMISE.
Rejections of the returned Promise are now forwarded to the promise returned by the promisified function instead of being left unhandled. If the callback has already settled the result, the rejection is rethrown so that it is still reported as an unhandled rejection rather than silently swallowed.
Refs: #49609
Refs: #49647
Refs: #49607