Skip to content

crypto: move DEP0031 to End-of-Life - #67493

Open
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:crypto-eol-dep0031
Open

jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:crypto-eol-dep0031

Conversation

@jasnell

@jasnell jasnell commented Nov 15, 2026

Copy link
Copy Markdown
Member

Remove ecdh.setPublicKey(). ECDH only requires a private key and the other party's public key to compute a shared secret, and ecdh.setPrivateKey() already derives and sets the associated public key. The native ECDH setPublicKey binding is removed as well.

diffieHellman.setPublicKey() is unaffected.

This has been a runtime deprecation since v25.0.0 and a documentation-only deprecation since v5.2.0.

Refs: #58620
Refs: #3511

Remove ecdh.setPublicKey(). ECDH only requires a private key and the
other party's public key to compute a shared secret, and
ecdh.setPrivateKey() already derives and sets the associated public
key. The native ECDH setPublicKey binding is removed as well.

diffieHellman.setPublicKey() is unaffected.

This has been a runtime deprecation since v25.0.0 and a
documentation-only deprecation since v5.2.0.

Refs: nodejs#58620
Refs: nodejs#3511
Assisted-by: Claude
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
jasnell requested a review from a team November 15, 2026 16:54
@jasnell jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Nov 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Nov 15, 2026
Comment thread doc/api/deprecations.md Resolved
@jasnell jasnell added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Nov 15, 2026
@panva
panva requested a review from a team November 15, 2026 16:56
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 15, 2026
@nodejs-github-bot

This comment was marked as outdated.

@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (d105ef7) to head (801b90c).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #67493   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files         799      799           
  Lines      280245   280225   -20     
  Branches    54125    54116    -9     
=======================================
+ Hits       254100   254104    +4     
+ Misses      16280    16275    -5     
+ Partials     9865     9846   -19     
Files with missing lines Coverage Δ
lib/internal/crypto/diffiehellman.js 97.70% <ø> (-0.03%) ⬇️
src/crypto/crypto_ec.cc 69.71% <ø> (+1.04%) ⬆️
src/crypto/crypto_ec.h 42.85% <ø> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 15, 2026
@github-actions github-actions Bot removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has conflicts with its base branch, removing the author ready label.
Please rebase your branch onto the latest base branch, resolve the conflicts locally, and force-push.
Afterwards the pull request needs a fresh collaborator approval, and a collaborator will add the label back once it is author ready again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants