Skip to content

chore(deps): enable pnpm strictPeerDependencies - #3344

Merged
gameroman merged 2 commits into
npmx-dev:mainfrom
cylewaitforit:pnpm-strict-peer-dependencies
Oct 23, 2026
Merged

gameroman merged 2 commits into
npmx-dev:mainfrom
cylewaitforit:pnpm-strict-peer-dependencies

Conversation

@cylewaitforit

@cylewaitforit cylewaitforit commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

🔗 Linked issue

resolves #3343

🧭 Context

Enables pnpm's strictPeerDependencies check and grandfathers the existing violations as explicit overrides.

📚 Description

This check helps ensure that the versions of packages used in the project work together.

@agentscanapp

agentscanapp Bot commented Oct 21, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! 🎉

We really appreciate you taking the time to contribute, @cylewaitforit.

A maintainer will take a look as soon as they can. In the meantime, please make sure that:

  • the description explains what changed and why
  • any related issues are linked
  • existing tests still pass

If anything needs adjusting we'll leave comments here. Thanks again!

@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs.npmx.dev Ready Ready Preview Oct 23, 2026 12:59am UTC
npmx.dev Building Building Preview Oct 23, 2026 12:59am UTC
1 Skipped Deployment
Project Deployment Actions Updated
npmx-lunaria Ignored Ignored Oct 23, 2026 12:59am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between ad31f62 and 39edc12.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 323d2d01-d8a2-4e3f-aebd-a6915ff92604
📥 Commits

Reviewing files that changed from the base of the PR and between 2074c81 and ad31f62.

📒 Files selected for processing: 1
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Enabled stricter validation for peer dependencies.
    • Updated dependency version allowances for build tooling, asset generation, command-line utilities, testing, and database support.

The workspace configuration enables strict peer dependency enforcement and adds allowed-version rules for vite-plus, @vite-pwa/assets-generator, cac and better-sqlite3.

Changes: Workspace dependency policy

Layer / File(s) Summary
Peer dependency and version rules
pnpm-workspace.yaml
The workspace enables strict peer dependency enforcement and adds allowed-version rules for four packages.

Suggested reviewers: graphieros

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to ad31f

The dependency-policy change is mergeable after normal checks; no actionable failure was established.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly describes the main change: enabling pnpm strictPeerDependencies. It uses a conventional commit format. The extra space does not affect clarity.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description directly matches the changes. It explains enabling pnpm strictPeerDependencies and adding explicit overrides for existing peer-dependency violations.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

e18e dependency analysis

No dependency warnings found.

@cylewaitforit cylewaitforit changed the title chore(pnpm): enable strictPeerDependencies chore(deps): enable pnpm strictPeerDependencies Oct 21, 2026
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@cylewaitforit
cylewaitforit marked this pull request as ready for review October 21, 2026 01:24
@serhalp
serhalp enabled auto-merge October 23, 2026 00:58
@serhalp
serhalp added this pull request to the merge queue Oct 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 23, 2026
@gameroman
gameroman added this pull request to the merge queue Oct 23, 2026
Merged via the queue into npmx-dev:main with commit bc37274 Oct 23, 2026
25 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 23, 2026

This branch was successfully deployed

2 active deployments
Preview – docs.npmx.dev — 39edc125 Deployed Oct 23, 2026 by vercel[bot]
Preview – npmx.dev — 39edc125 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable pnpm strictPeerDependencies check

3 participants