Repository navigation
DEV: add spin bench command for local benchmarks - #159
Merged
Merged
Conversation
naseweisssss
marked this pull request as ready for review
October 4, 2026 08:57
github-project-automation
Bot
moved this to Open
in NF Sustaining Open Source Series 2026
InessaPawson
reviewed
Oct 4, 2026
InessaPawson
reviewed
Oct 4, 2026
Co-authored-by: Inessa Pawson <inessapawson@gmail.com>
Co-authored-by: Inessa Pawson <inessapawson@gmail.com>
InessaPawson
reviewed
Oct 4, 2026
InessaPawson
reviewed
Oct 4, 2026
InessaPawson
left a comment
InessaPawson
left a comment
Member
There was a problem hiding this comment.
Thanks for picking this up, @naseweisssss! Nice work!
One more inline comment to address. Also, the prefix DEV fits this PR better than BUG.
Co-authored-by: Inessa Pawson <inessapawson@gmail.com>
naseweisssss
changed the title
InessaPawson
approved these changes
Oct 4, 2026
seberg
approved these changes
Oct 5, 2026
seberg
left a comment
seberg
left a comment
Member
There was a problem hiding this comment.
LGTM and seems to all work as advertised and the biggest nit I found is that the lines could be wrapped nicer in the markdown.
Thanks, @naseweisssss, let's get it in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is aimed to solve: #123. Added a minimal spin bench to build the local checkout and run the existing ASV benchmarks.
Verified the full benchmark and benchmark selection, including that ASV imports the local build
Benchmark validation
Ran:
All 27 parameter combinations completed successfully.
Selected results (timing uncertainty omitted):
Tested on Windows with Python 3.13.15, Spin 0.18, and ASV 0.6.6. Verified that ASV imports the local build.
These results validate the existing
npvbenchmark through the new command; they do not demonstrate a performance improvement.