Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nperloses accuracy for very small nonzero rates because intermediate arithmetic rounds the logarithm's argument towards one. This can affect otherwise ordinary loan and savings calculations.Use
log1pand an algebraically equivalent correction near zero, avoiding division of payments by the rate in that branch. Retain the existing path outside this region and the existing zero-rate, interest-only and invalid-domain behavior. This addresses the numerical stability part of #119; it does not settle the separate proposals for undefined or infinite solutions.Validation: 138 tests pass, including 28 added cases checked against high-precision Decimal calculations or existing boundary behavior. Ruff, Pyright and Mypy pass.
Prepared with AI assistance.