Repository navigation
DOC: correct MIRR formula and period count - #171
Open
milliondreamsblog wants to merge 1 commit into
Open
milliondreamsblog wants to merge 1 commit into
milliondreamsblog wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MIRR Notes formula multiplies by an extra reinvestment factor even though its
FV_positivedefinition already includes reinvestment. Remove that factor, use the magnitude of the negative-flow present value, and define the exponent using the elapsed number of periods,N = len(values) - 1for one cash-flow series.Use single backslashes for the LaTeX commands inside the raw docstring so MathJax can render the equation correctly.
For
[-120000, 39000, 30000, 21000, 37000, 46000]with finance rate 0.10 and reinvestment rate 0.12, the corrected formula agrees with the function at 12.6094%; the extra factor gives 26.1225%.This changes only the docstring. Validation: the native package builds on Python 3.13/Linux; all 118 package tests and doctests pass; the Sphinx HTML build passes with
-W --keep-going; and the generated MIRR equation and explanation were checked. An AST comparison confirms no executable code changed.