Repository navigation
git and gh completions: one extern per tool, alias-aware, full coverage - #1312
Merged
Merged
Conversation
fdncred
force-pushed
the
update_gh_git_completions
branch
from
November 16, 2026 17:18
2777e50 to
3cac6bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
custom-completions/gitandcustom-completions/ghdrop their per-subcommand externs (57 for git, 40 for gh). Each file now has a single extern with no declared flags, plus a completer that works out the command from the words on the line.How one git tab press is resolved:
Declaring no flags is deliberate. Every declared flag changes what git or gh receives:
--x=vfails to parse, and gh's--draft=falseis sent as--draft false.--xat the end of the line fails to parse.-n5,-Xtheirs,-uno) fail to parse.gitextern applied that to aliases (see Evidence).--help: prints Nushell's help instead of the tool's.Undeclared arguments pass through untouched, and the completer still offers every flag.