Repository navigation
Conversation
lforchini
force-pushed
the
fix-double-path-bug
branch
from
October 29, 2026 14:29
82c32e8 to
7628305
Compare
lforchini
force-pushed
the
fix-double-path-bug
branch
from
October 30, 2026 10:49
7628305 to
fc21251
Compare
lforchini
marked this pull request as ready for review
October 30, 2026 10:51
tmakatos
reviewed
Oct 30, 2026
tmakatos
left a comment
tmakatos
left a comment
Collaborator
There was a problem hiding this comment.
Is this a bug fix or a minor improvement? I would think the former since we use util::Path which means it could be /foo/proc/... and because of the intermediate (util::)Path::new it would end up as /foo/foo/proc/..., right?
Nit, doesn't the prefix get prepended, not appended?
lforchini
force-pushed
the
fix-double-path-bug
branch
from
November 5, 2026 15:03
fc21251 to
e5ce185
Compare
lforchini
changed the base branch from
test/refactor-config-loading
to
refactor/util-path
November 5, 2026 15:03
lforchini
force-pushed
the
fix-double-path-bug
branch
from
November 5, 2026 15:10
e5ce185 to
7923751
Compare
lforchini
force-pushed
the
fix-double-path-bug
branch
from
November 6, 2026 10:24
7923751 to
be6f7e9
Compare
Collaborator
Author
|
It's a bugfix for the reason you mention. I've updated the commit message to say prepend. |
lforchini
force-pushed
the
fix-double-path-bug
branch
2 times, most recently
from
November 13, 2026 09:38
fc19b11 to
4a5bde5
Compare
In some instances, a prefix could be prepended twice. Some config loading functions would take a `util::Path` (prefixed), convert it to a `std::*::Path` (still prefixed), and then convert it to a `util::Path` again, doubling the prefix. Don't perform this intermediate step, directly append to the `util::Path`. Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
lforchini
force-pushed
the
fix-double-path-bug
branch
from
November 13, 2026 09:55
4a5bde5 to
fc5b3ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some instances, a prefix could be appended twice. Some config
loading functions would take a
util::Path(prefixed), convert it to astd::*::Path(still prefixed), and then convert it to autil::Pathagain, doubling the prefix. Don't perform this intermediate step,
directly append to the
util::Path.Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬