Repository navigation
Conversation
lforchini
force-pushed
the
test/modify-existing
branch
from
October 29, 2026 14:29
dab07a4 to
86b8218
Compare
lforchini
force-pushed
the
test/modify-existing
branch
from
October 30, 2026 10:49
86b8218 to
cd9207b
Compare
lforchini
marked this pull request as ready for review
October 30, 2026 10:52
lforchini
force-pushed
the
test/modify-existing
branch
from
October 30, 2026 11:43
cd9207b to
b6339fd
Compare
tmakatos
reviewed
Oct 30, 2026
tmakatos
left a comment
tmakatos
left a comment
Collaborator
There was a problem hiding this comment.
Minor phrasing nits, LGTM otherwise.
lforchini
force-pushed
the
test/modify-existing
branch
from
November 5, 2026 15:03
b6339fd to
0339909
Compare
lforchini
force-pushed
the
test/modify-existing
branch
from
November 5, 2026 15:10
0339909 to
3bdee91
Compare
lforchini
force-pushed
the
test/modify-existing
branch
from
November 6, 2026 10:24
3bdee91 to
a05aa2c
Compare
lforchini
force-pushed
the
test/modify-existing
branch
3 times, most recently
from
November 13, 2026 09:38
4d740be to
60b4115
Compare
Rename tests to use the `test_` prefix and refactor the bodies of some tests. Also change Config::default to match its serde default. Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
lforchini
force-pushed
the
test/modify-existing
branch
from
November 13, 2026 09:55
60b4115 to
06777e7
Compare
tmakatos
reviewed
Nov 13, 2026
tmakatos
left a comment
tmakatos
left a comment
Collaborator
There was a problem hiding this comment.
I'd prefer this split into separate commits, e.g. prepending test_ in its own commit, rewording tests in own commit, etc. Also, could you explain the need for the refactor?
Collaborator
See newer comment, this should be split. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename tests to use the
test_prefix and refactor the bodies of sometests. Also change Config::default to match its serde default.
Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬