[lforchini]

Rename our custom Path to be PrefixedPath to prevent the collision with
std's Path. Also move it to its own dedicated path module instead of the
generic util.rs. Update all usages to use the new name and module.

The new name, PrefixedPath, should improve clarity when converting to
and from std's Path.

Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[tmakatos]

What's the collision problem? I prefer the fact that we don't have to explicitly a different type othen than Path, plus using PrefixedPath feels heavier from a mental point of view (and it's conceptually not much different than explicitly passing the root directory everywhere as an extra argument).

[lforchini]

I find that both being Path increases the cognitive load because I keep having to figure out whether it's ours or std's. For now, I've been using our path as just Path and std's as std::path::Path to try and lessen the ambiguity. I think using a different name removes cognitive overhead instead of adding it.

Maybe we can add an extension trait to std Path which can add the prefix to add a new_with_root constructor? I could also change the name to something more subtle like PPath?

[tmakatos]

Maybe we can add an extension trait to std Path which can add the prefix to add a new_with_root constructor?

If that avoids having to introduce a new name I'd prefer it.