Repository navigation
Fix formatting - #177
Open
lforchini wants to merge 2 commits into
Open
Fix formatting#177lforchini wants to merge 2 commits into
lforchini wants to merge 2 commits into
Conversation
Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
tmakatos
reviewed
Nov 6, 2026
tmakatos
left a comment
tmakatos
left a comment
Collaborator
There was a problem hiding this comment.
Is this something make check caught? If so, shouldn't CI have failed and block merging this commit?
Collaborator
Author
|
All my other PRs were failing CI because of this formatting issue. CI failed on #168 but the PR was still mergeable. |
Collaborator
Author
|
The settings should've been updated now, we shouldn't be able to merge without all the checks passing. |
tmakatos
approved these changes
Nov 13, 2026
It appears that the new Rust 1.100 has changed how comments are wrapped. Fix the new formatting violations. Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬