Repository navigation
Conversation
tmakatos
approved these changes
Nov 13, 2026
lforchini
force-pushed
the
fix/flaky-test
branch
from
November 13, 2026 09:38
7e1c1c1 to
243c81a
Compare
Don't assert on the contents of log lines, instead use a fake client capable of storing history. In the future, this client should be replaced by the universal unit-testing client requested in #130 but should suffice for now. The issue seemed to be a race between parallel tests on the tracing setup where tracing may incorrectly cache that an event call site is ignored, causing it to drop events. This manifested as missing log lines in the per-vm log. This bug should be testing specific since the actual application only has a single dispatcher. Therefore start to remove tests which assert the contents of logs in favor of the actual events. AI-Generated: Diagnosis Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
lforchini
force-pushed
the
fix/flaky-test
branch
from
November 13, 2026 09:55
243c81a to
10ae286
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't assert on the contents of log lines, instead use a fake client
capable of storing history. In the future, this client should be
replaced by the universal unit-testing client requested in #130 but
should suffice for now.
The issue seemed to be a race between parallel tests on the tracing
setup where tracing may incorrectly cache that an event call site is
ignored, causing it to drop events. This manifested as missing log lines
in the per-vm log. This bug should be testing specific since the actual
application only has a single dispatcher. Therefore start to remove
tests which assert the contents of logs in favor of the actual events.
AI-Generated: Diagnosis
Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬