Repository navigation
Conversation
lforchini
force-pushed
the
test/read-fake-proc
branch
from
October 1, 2026 14:48
b211288 to
96c5727
Compare
lforchini
force-pushed
the
test/read-fake-proc
branch
from
October 5, 2026 08:10
96c5727 to
275ec7f
Compare
lforchini
marked this pull request as ready for review
October 5, 2026 08:23
lforchini
force-pushed
the
test/read-fake-proc
branch
from
October 5, 2026 08:49
275ec7f to
7088f29
Compare
lforchini
force-pushed
the
test/read-fake-proc
branch
from
October 8, 2026 07:30
7088f29 to
d5c3914
Compare
lforchini
force-pushed
the
test/read-fake-proc
branch
2 times, most recently
from
October 8, 2026 15:23
d5c3914 to
a0dc5c3
Compare
lforchini
force-pushed
the
test/read-fake-proc
branch
from
October 13, 2026 12:43
a0dc5c3 to
d453199
Compare
lforchini
force-pushed
the
test/read-fake-proc
branch
from
October 13, 2026 13:17
d453199 to
4356bb5
Compare
tmakatos
reviewed
Oct 21, 2026
| /// `procfs::process::Process::new` always opens the real `/proc`. Callers | ||
| /// that should honor the mock root pass this path to | ||
| /// `Process::new_with_root`. | ||
| pub fn proc_pid(pid: i32) -> std::path::PathBuf { |
Collaborator
There was a problem hiding this comment.
Not sure this function belongs here, I don't feel too strongly though.
|
|
||
| use futures_util::future::join_all; | ||
| use procfs::{CpuPressure, Current, CurrentSI, IoPressure, MemoryPressure, ProcError}; | ||
| use procfs::{CpuPressure, Current, FromReadSI, IoPressure, MemoryPressure, ProcError}; |
Collaborator
There was a problem hiding this comment.
What's this change about?
Collaborator
Author
There was a problem hiding this comment.
I had to build KernelStats from a file and current_system_info and that needed different traits.
lforchini
force-pushed
the
test/read-fake-proc
branch
from
October 23, 2026 08:24
4356bb5 to
31db8c0
Compare
lforchini
force-pushed
the
test/read-fake-proc
branch
from
October 29, 2026 14:29
31db8c0 to
62ac932
Compare
lforchini
force-pushed
the
test/read-fake-proc
branch
from
October 30, 2026 10:49
62ac932 to
13ecd01
Compare
lforchini
force-pushed
the
test/read-fake-proc
branch
from
November 5, 2026 15:03
13ecd01 to
b85180b
Compare
lforchini
force-pushed
the
test/read-fake-proc
branch
from
November 5, 2026 15:10
b85180b to
e0f6155
Compare
tmakatos
approved these changes
Nov 6, 2026
lforchini
force-pushed
the
test/read-fake-proc
branch
from
November 6, 2026 10:24
e0f6155 to
3043674
Compare
tmakatos
approved these changes
Nov 13, 2026
lforchini
force-pushed
the
test/read-fake-proc
branch
from
November 13, 2026 09:38
3043674 to
dda077a
Compare
Host CPU and per-task samples were opening the real /proc, so IO_THREAD_CONTROLLER_ROOT_PATH could not redirect them at a test directory. Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
lforchini
force-pushed
the
test/read-fake-proc
branch
from
November 13, 2026 09:55
dda077a to
beaebe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Host CPU and per-task samples were opening the real /proc, so
IO_THREAD_CONTROLLER_ROOT_PATH could not redirect them at a test
filesystem.
Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬