[lforchini]

Fixed a bug where the util::Path prefix was appended twice in some
cases, and also consolidated config loading into a single function.
It attempts to read the config file and falls back the a default
implementation if not found.

Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[tmakatos]

Can you explain what problem the refactor solves?

[lforchini]

Sure, there's two separate bugs: one is that it would apply the prefix mechanism twice, and secondly I consolidated the three config loading mechanisms into a single one that falls back onto a default config if it's not found. addressing this todo: // TODO TOCTOU, blindly load and return default if ENOENT.

[tmakatos]

Sure, there's two separate bugs: one is that it would apply the prefix mechanism twice, and secondly I consolidated the three config loading mechanisms into a single one that falls back onto a default config if it's not found. addressing this todo: // TODO TOCTOU, blindly load and return default if ENOENT.

Shouldn't this be three separate commits then?

[lforchini]

I've split it out since I wrote that since I realised the same thing 😄, this commit is just the "use default if ENOENT" applied globally like the fixme suggests.