Repository navigation
Conversation
lforchini
force-pushed
the
test/refactor
branch
from
October 1, 2026 14:48
2210b6a to
5b9e507
Compare
lforchini
commented
Oct 1, 2026
lforchini
force-pushed
the
test/refactor
branch
from
October 1, 2026 15:00
5b9e507 to
9ba1454
Compare
lforchini
force-pushed
the
test/refactor
branch
from
October 5, 2026 08:10
9ba1454 to
b415436
Compare
lforchini
force-pushed
the
test/refactor
branch
from
October 5, 2026 08:15
b415436 to
010cb37
Compare
lforchini
marked this pull request as ready for review
October 5, 2026 08:27
lforchini
force-pushed
the
test/refactor
branch
from
October 5, 2026 08:49
010cb37 to
31e23e7
Compare
lforchini
force-pushed
the
test/refactor
branch
from
October 8, 2026 07:30
31e23e7 to
bb7b5e0
Compare
lforchini
force-pushed
the
test/refactor
branch
from
October 8, 2026 15:23
bb7b5e0 to
e9bad57
Compare
lforchini
force-pushed
the
test/refactor
branch
from
October 13, 2026 12:43
e9bad57 to
474c8c6
Compare
lforchini
force-pushed
the
test/refactor
branch
from
October 13, 2026 13:17
474c8c6 to
7730851
Compare
lforchini
force-pushed
the
test/refactor
branch
from
October 23, 2026 08:24
03c900a to
9a61df9
Compare
lforchini
force-pushed
the
test/refactor
branch
from
October 29, 2026 14:29
9a61df9 to
46e9f00
Compare
lforchini
force-pushed
the
test/refactor
branch
from
October 30, 2026 10:49
46e9f00 to
0ca60e7
Compare
lforchini
force-pushed
the
test/refactor
branch
from
November 5, 2026 15:03
0ca60e7 to
a3c884b
Compare
lforchini
force-pushed
the
test/refactor
branch
from
November 5, 2026 15:10
a3c884b to
de540fe
Compare
lforchini
force-pushed
the
test/refactor
branch
from
November 6, 2026 10:24
de540fe to
a91298c
Compare
Collaborator
Author
|
I've updated the commit message and also the PR body. |
lforchini
force-pushed
the
test/refactor
branch
2 times, most recently
from
November 13, 2026 09:38
d40f0c5 to
2755ad8
Compare
Proptest allows for checking general properties instead of just single instances. This commit modifies some tests to use proptest. Previously, the thread_id <-> vq mapping was tested by creating some thread ids, having a fixed number of VQs, then checking those specific inputs were reasonably assigned. Now, we generate 0..8 ids and 0..128 vqs and ensure any combination assigns VQs reasonably. Similarly, proptest is used to ensure that `next_qemu_iothread_id` really does pick the lowest thread_id, no matter what has already been assigned. Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
lforchini
force-pushed
the
test/refactor
branch
from
November 13, 2026 09:55
2755ad8 to
2ee5d76
Compare
tmakatos
reviewed
Nov 13, 2026
tmakatos
left a comment
tmakatos
left a comment
Collaborator
There was a problem hiding this comment.
There's still some comments open so I can't tell whether it's ready for review. Also I see some force pushes, can you instead add fixup commits so I can track what changed more easily?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proptest allows for checking general properties instead of just single
instances. This commit modifies some tests to use proptest.
Previously, the thread_id <-> vq mapping was tested by creating some
thread ids, having a fixed number of VQs, then checking those specific
inputs were reasonably assigned. Now, we generate 0..8 ids and 0..128
vqs and ensure any combination assigns VQs reasonably.
Similarly, proptest is used to ensure that
next_qemu_iothread_idreally does pick the lowest thread_id, no matter what has already been
assigned.
Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬