fix: use setGlobalProxyFromEnv to enable proxy - #1577
Conversation
commit: |
CLI benchmark
Full report
|
| Setting | Value |
|---|---|
| Baseline | ref:8babb655c5f6ca4359eda60a7ea8871b1befa4cb (v4.0.0-alpha.1) |
| Head | local packages/nuxt-cli at 42e78ae (v4.0.0-alpha.1) |
| Node | v24.21.0 |
| OS | Linux 6.17.0 (kernel 6.17.0-1022-azure) |
| CPU | AMD EPYC 7763 64-Core Processor x 4 |
| Memory | 15.6 GB |
| Load average at start | 0.95, 0.28, 0.10 |
| Run started | 2026-09-29T03:26:46.193Z |
Cold CLI startup
Median of 15 interleaved runs per command, one warmup discarded.
| Command | baseline v4.0.0-alpha.1 median | head v4.0.0-alpha.1 median | Delta | baseline v4.0.0-alpha.1 min / p95 | head v4.0.0-alpha.1 min / p95 |
|---|---|---|---|---|---|
nuxt --version |
69 ms | 91 ms | +32.9% | 66 ms / 73 ms | 88 ms / 95 ms |
nuxt --version (first output byte) |
64 ms | 86 ms | +33.4% | 61 ms / 68 ms | 82 ms / 89 ms |
nuxt --help |
149 ms | 148 ms | -0.7% | 146 ms / 154 ms | 146 ms / 155 ms |
nuxt --help (first output byte) |
144 ms | 142 ms | -1.1% | 141 ms / 149 ms | 140 ms / 149 ms |
nuxt dev --help |
108 ms | 107 ms | -0.7% | 104 ms / 113 ms | 103 ms / 111 ms |
nuxt dev --help (first output byte) |
102 ms | 102 ms | -0.2% | 98 ms / 108 ms | 98 ms / 106 ms |
nuxt <unknown-command> (no-op) |
158 ms | 160 ms | +1.2% | 155 ms / 160 ms | 156 ms / 163 ms |
nuxt <unknown-command> (no-op) (first output byte) |
152 ms | 154 ms | +1.3% | 150 ms / 154 ms | 150 ms / 157 ms |
Module load cost
Counted with a module.registerHooks load hook, compile cache disabled. Counts every JS module actually evaluated on that code path (built-ins excluded, native addons excluded).
| Command | baseline v4.0.0-alpha.1 modules | head v4.0.0-alpha.1 modules | Delta | baseline v4.0.0-alpha.1 source bytes | head v4.0.0-alpha.1 source bytes | Delta |
|---|---|---|---|---|---|---|
nuxt --version |
36 | 37 | +2.8% | 296.6 kB | 296.8 kB | +0.1% |
nuxt --help |
143 | 143 | 0.0% | 960.2 kB | 960.4 kB | +0.0% |
nuxt dev --help |
62 | 62 | 0.0% | 451.3 kB | 451.5 kB | +0.0% |
Install footprint and published tarball
Each version installed on its own into an empty project with nothing but @nuxt/cli as a dependency, so the tree is exactly the CLI and its transitive dependencies. npm cache is warm and the registry is only consulted for metadata, so install wall time is indicative, not a network benchmark.
| Metric | baseline v4.0.0-alpha.1 | head v4.0.0-alpha.1 | Delta |
|---|---|---|---|
Direct dependencies of @nuxt/cli |
22 | 22 | 0.0% |
| Packages in the installed tree (unique name@version) | 38 | 38 | 0.0% |
| Unique package names | 38 | 38 | 0.0% |
| Package directories on disk (cross-check) | 31 | 31 | 0.0% |
Installed node_modules on disk |
2.40 MB | 2.40 MB | +0.0% |
| Installed files | 421 | 421 | 0.0% |
| Install wall time (warm npm cache, median of 3) | 1.33 s | 1.32 s | -0.8% |
| Published tarball (packed) | 238.0 kB | 238.1 kB | +0.0% |
| Published tarball (unpacked) | 775.2 kB | 775.4 kB | +0.0% |
| Files in tarball | 98 | 98 | 0.0% |
Interleaved runs on a shared runner: trust the deltas, not the absolute timings. The dev, restart and build suites run locally via pnpm bench:cli.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Merge Risk: ⚪ Minimal · up to The change enables environment-based proxy support in create-nuxt and nuxi, and it is respected when explicitly disabled. No merge-blocking risk was identified. Security Architecture ReviewSecurity architecture risk: 🟡 Moderate · up to Proxy settings inherited by the CLI can now route its own network requests, including update checks, through a configured proxy. Explicit opt-out and proxy bypass settings limit that change, but the broader routing deserves review. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
📚 Description
use node's built in
setGlobalProxyFromEnvwhere it's available to enable proxy without the need for a user to set an env variable