Repository navigation
Conversation
The two argument_list patterns were wrapped in an extra paren pair, making them a single grouped pattern requiring two consecutive sibling argument_list nodes (which never occurs), so @parameter never matched function arguments. Replaced them with the two-pattern form already used for tuple_expression, which additionally handles single-argument calls that the comma-anchored patterns could not match.
The short-form pattern failed to match cases with a where clause. The alternation ensures that the pattern now matches cases both with and without a where clause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query for arguments in function argument lists was malformed, inadvertently grouping two queries that should have been separate. By adopting the form already used for tuple expressions, the patterrn also matches single-argument function calls, which the previous pattern would not have. Furthermore, the query for short-form function definitions did not match if a where clause was present.
If preferable, the alternation in the short-form query correction is easily substituted by two separate queries.
Tested with:
Verified with :EditQuery that both patterns match the intended
nodes, and that the
@parameterand@functiontext objects and motions behave correctly.