feat(#553): add test-word lint - #1237
Open
VasilevNStas wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@volodya-lombrozo please review, I`m fixed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #553.
Problem
Objects with names containing the word
test(case-insensitive) are allowed, while the project convention requires test names to be clean. Such names should lead to lint warnings.Solution / What
New XSLT lint
test-wordthat warns when an object name containstestin a test context: object names inside test objects (matched by theeo:test-name()helper), their ancestors, or when the top-level object name ends with-tests.Changes
src/main/resources/org/eolang/lints/tests/test-word.xsl— the new lint.src/main/resources/org/eolang/motives/tests/test-word.md— motivation.src/test/resources/org/eolang/lints/packs/single/test-word/— 5 test packs.Tests
catches-test-in-test-objectcatches-test-word-in-helpercatches-test-in-nested-objectallows-clean-test-namesallows-test-word-in-regular-object