feat(lint,cli): JSX gate full validation via manifest (ADR-0080 M3b①)#2446
Merged
Conversation
…ent (ADR-0080 M3b①) validateJsxPages accepts an optional component manifest -> compile()-based full validation (unknown component / missing-required / enum / type); without it, parse-level. os validate loads sdui.manifest.json from the project root when present. Generating+shipping that manifest from the registry public tier stays a build/CI step. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 15 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-0080 M3b① — the manifest consumption seam. The
os build/os validateJSX gate (#2440) now upgrades from parse-level to full component/prop validation when asdui.manifest.jsonis present at the project root: unknown component, missing/wrong prop, bad enum, and binding sites — via@objectstack/sdui-parser'scompile(). Without a manifest it falls back to parse-level (syntax/structure/forbidden constructs), so nothing regresses.Verified:
validateJsxPageswith a manifest catches unknown-component + missing-required and passes a valid page; without a manifest it stays parse-level. No new deps (node builtins).Remaining (the genuinely cross-repo bit): generating + shipping the manifest — the registry's public tier (
getPublicConfigs, objectui) serialized intosdui.manifest.jsonand made available to the build. That's a CI/release step (boot registry → emit JSON), plus the eventual@object-ui/sdui-parserre-export once@objectstack/sdui-parseris published. The consumption side is now in place and dormant-until-fed.🤖 Generated with Claude Code