feat(spec,objectql): ADR-0079 — wire provisionPrimary (designate-only) at object registry#2458
Merged
Merged
Conversation
…) at registry
- display-name.ts: provisionPrimary gains a { synthesize?: boolean } option.
synthesize:false designates an existing title-eligible field as nameField
but NEVER synthesizes a new `name` column (no DB-schema migration).
- registry.ts: SchemaRegistry.registerObject calls provisionPrimary(schema,
{synthesize:false}) at the materialization seam (own ownership) — so
nameField is reliably populated for normal/user/AI-built objects, while
fieldless system tables are left untouched (no migration). Replaces the
staged TODO(ADR-0079).
- Migration sweep helper/command for existing envs.
Gates: spec 6650/6650 + liveness + api-surface; objectql 723/723 — green.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 95 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the ADR-0079 structural invariant safely: every normal object gets a reliably-populated
nameFieldat registration, with no DB-schema migration.provisionPrimarygains{ synthesize?: boolean }.synthesize:falsedesignates an existing title-eligible field asnameFieldwhen undeclared, but never synthesizes a newnamecolumn.SchemaRegistry.registerObjectcallsprovisionPrimary(schema, { synthesize: false })at the materialization seam (own ownership) — replacing the stagedTODO(ADR-0079). SonameFieldis reliably set for user/AI-built objects (which always have a text label), while fieldless system tables (sys_record_share, …) are left untouched (no migration, the reason this was deferred). Title-less objects still fall to the resolver'sRecord #<id>floor.Gates:
@objectstack/spec6650/6650 + liveness + api-surface;@objectstack/objectql723/723 — all green.🤖 Generated with Claude Code