fix(spec): PROTOCOL_VERSION 12→13 — restore package-major lockstep (unbreaks main)#2731
Closed
os-zhuang wants to merge 1 commit into
Closed
fix(spec): PROTOCOL_VERSION 12→13 — restore package-major lockstep (unbreaks main)#2731os-zhuang wants to merge 1 commit into
os-zhuang wants to merge 1 commit into
Conversation
…ockstep The ADR-0090 P1 major shipped in 13.0.0 (#2720) without bumping the handshake constant; protocol-version.test.ts (the guard for exactly this) now fails on main and blocks every PR's Test Core. Protocol 13 is correct: the P1 renames are an authorable-surface break the handshake must refuse across majors. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 93 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
Contributor
Author
|
Superseded — #2726 landed the same one-line fix first. Closing; branch deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red:
Test Corefails on every PR since the 13.0.0 release (#2720) — the ADR-0090 P1 major shipped without bumpingPROTOCOL_VERSION(still12.0.0), andprotocol-version.test.ts(the lockstep guard built for exactly this) caught it.One-line fix:
PROTOCOL_VERSION→13.0.0.Protocol 13 is semantically correct, not just test-appeasement: the P1 wave's alias-free renames (
roles:→positions:, kindsrole/profile→position, OWD legacy values dropped) are precisely the authorable-surface break theengines.protocolhandshake exists to refuse across majors — a package authored for^12genuinely won't load right on 13.Verified: spec 6672 ✓ (incl. the lockstep guard), metadata-core 100 ✓ (handshake consumer). No
^12pins exist in examples/templates in-repo.Unblocks #2728 and every other open PR.
🤖 Generated with Claude Code