feat: expose extended branding fields in runtime config API#2799
Merged
os-zhuang merged 2 commits intoJul 11, 2026
Conversation
Add logoUrl, faviconUrl, brandColor, pwaDescription, and pwaThemeColor to the /api/v1/runtime/config response, driven by corresponding OS_* environment variables. Also decouples /runtime/assets/* serving from the console plugin into a standalone createRuntimeAssetsPlugin so branding assets resolve even when the console dist hasn't been built yet. Accepts an optional OS_RUNTIME_ASSETS_DIR override; falls back to process.cwd()/assets. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@akarma-synetal is attempting to deploy a commit to the Object Stack Team on Vercel. A member of the Team first needs to authorize it. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL flagged js/insecure-temporary-file (high) on the test: it built a temp dir from a predictable `Date.now()` name and wrote into it, which is open to a temp-file race / symlink attack in the shared OS temp dir. Use fs.mkdtempSync() to atomically create a uniquely-named directory with a random suffix — the pattern CodeQL recognizes as safe — and drop the now redundant mkdirSync. Behavior is otherwise unchanged; all 3 tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logoUrl,faviconUrl,brandColor,pwaDescription,pwaThemeColorin/api/v1/runtime/configresponseOS_*environment variables/runtime/assets/*serving into a standalonecreateRuntimeAssetsPluginso branding assets (logos, favicons) resolve even when the console dist hasn't been builtOS_RUNTIME_ASSETS_DIRoverride; falls back toprocess.cwd()/assetsTest plan
OS_LOGO_URL,OS_FAVICON_URL,OS_BRAND_COLOR,OS_PWA_THEME_COLORenv vars and verify response/runtime/assets/:filenameserves 200 when file exists, 404 when missingMade with Cursor