feat(approvals): label pending-approver chips with their group (#2807)#2811
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
…tui#2807) The drawer's 'waiting on' chips now key their collapse by (name, group) using the framework's pending_approver_groups: the same person filling two groups stays two labeled chips (Dev Admin · finance / · legal), one group filled twice collapses to a single chip with a count. Group renders as a muted · <group> sub-tag. Degrades to plain dedupe + count when no group data present. Rebased onto latest main (resolves overlap with the #2810 admin-override change in the same file). Closes objectui#2807 (UI half) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz
os-zhuang
force-pushed
the
claude/approval-center-optimization-77msf2
branch
from
July 24, 2026 16:16
a25af02 to
30f08ef
Compare
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Jul 25, 2026
…tui#2807) (objectstack-ai#2811) The drawer's 'waiting on' chips now key their collapse by (name, group) using the framework's pending_approver_groups: the same person filling two groups stays two labeled chips (Dev Admin · finance / · legal), one group filled twice collapses to a single chip with a count. Group renders as a muted · <group> sub-tag. Degrades to plain dedupe + count when no group data present. Rebased onto latest main (resolves overlap with the objectstack-ai#2810 admin-override change in the same file). Closes objectui#2807 (UI half) Claude-Session: https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UI half of #2807 (a follow-up to #2762 P1-2). The dedupe pass (#2803) collapsed repeated "waiting on" chips to one with a
×Ncount, but couldn't say which group (finance / legal / …) each pending approver represents in a 会签 (per_group) request — the data wasn't there. With the framework now emittingpending_approver_groups(companion PR objectstack-ai/objectstack#3458), the drawer:(name, group)— the same person filling two different groups stays two labeled chips (Dev Admin · finance,Dev Admin · legal), while one group filled twice collapses to a single chip with a count;· <group>sub-tag on the chip.Degrades cleanly: with no group data (non-
per_group, or an older backend that predates the framework field) the collapse key is the name alone — identical to today's plain dedupe +×N. Group names come from the data, so no new locale strings.Verification
turbo buildgreen for@object-ui/consoleeslinton the touched files: no new errors (ApprovalsInboxPagestays at the same 9 pre-existingreact-hookserrors as main)@object-ui/console)Depends on: objectstack-ai/objectstack#3458 (the
pending_approver_groupsenrichment). Safe to merge independently — the UI degrades to dedupe-only until the framework field ships.Closes #2807 (UI half)
🤖 Generated with Claude Code
https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz
Generated by Claude Code