Skip to content

feat(approvals): label pending-approver chips with their group (#2807)#2811

Merged
os-zhuang merged 1 commit into
mainfrom
claude/approval-center-optimization-77msf2
Jul 24, 2026
Merged

feat(approvals): label pending-approver chips with their group (#2807)#2811
os-zhuang merged 1 commit into
mainfrom
claude/approval-center-optimization-77msf2

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Summary

UI half of #2807 (a follow-up to #2762 P1-2). The dedupe pass (#2803) collapsed repeated "waiting on" chips to one with a ×N count, but couldn't say which group (finance / legal / …) each pending approver represents in a 会签 (per_group) request — the data wasn't there. With the framework now emitting pending_approver_groups (companion PR objectstack-ai/objectstack#3458), the drawer:

  • keys the chip collapse by (name, group) — the same person filling two different groups stays two labeled chips (Dev Admin · finance, Dev Admin · legal), while one group filled twice collapses to a single chip with a count;
  • renders the group as a muted · <group> sub-tag on the chip.

Degrades cleanly: with no group data (non-per_group, or an older backend that predates the framework field) the collapse key is the name alone — identical to today's plain dedupe + ×N. Group names come from the data, so no new locale strings.

Verification

  • turbo build green for @object-ui/console
  • eslint on the touched files: no new errors (ApprovalsInboxPage stays at the same 9 pre-existing react-hooks errors as main)
  • Changeset: patch (@object-ui/console)

Depends on: objectstack-ai/objectstack#3458 (the pending_approver_groups enrichment). Safe to merge independently — the UI degrades to dedupe-only until the framework field ships.

Closes #2807 (UI half)

🤖 Generated with Claude Code

https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz


Generated by Claude Code

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 24, 2026 4:16pm

Request Review

@os-zhuang os-zhuang closed this Jul 24, 2026
@os-zhuang os-zhuang reopened this Jul 24, 2026
@os-zhuang
os-zhuang marked this pull request as ready for review July 24, 2026 16:07
…tui#2807)

The drawer's 'waiting on' chips now key their collapse by (name, group) using
the framework's pending_approver_groups: the same person filling two groups
stays two labeled chips (Dev Admin · finance / · legal), one group filled
twice collapses to a single chip with a count. Group renders as a muted
· <group> sub-tag. Degrades to plain dedupe + count when no group data present.

Rebased onto latest main (resolves overlap with the #2810 admin-override
change in the same file).

Closes objectui#2807 (UI half)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz
@os-zhuang
os-zhuang force-pushed the claude/approval-center-optimization-77msf2 branch from a25af02 to 30f08ef Compare July 24, 2026 16:16
@github-actions github-actions Bot added the apps label Jul 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.0 KB 350 KB
Entry file index-y-O8Mg71.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.19KB 2.96KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.14KB 97.88KB
core (index.js) 1.86KB 0.63KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 125.29KB 31.48KB
fields (index.js) 211.69KB 51.79KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.90KB 2.15KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.37KB 12.48KB
plugin-charts (index.js) 46.90KB 13.26KB
plugin-chatbot (index.js) 179.53KB 42.79KB
plugin-dashboard (index.js) 108.71KB 28.00KB
plugin-designer (index.js) 210.92KB 42.69KB
plugin-detail (index.js) 214.78KB 52.42KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.47KB 25.10KB
plugin-gantt (index.js) 162.33KB 39.53KB
plugin-grid (index.js) 174.13KB 45.90KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.59KB 23.27KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.81KB 9.98KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.70KB 20.87KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.00KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 2.02KB 0.95KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit b5f4e0f into main Jul 24, 2026
22 of 23 checks passed
@os-zhuang
os-zhuang deleted the claude/approval-center-optimization-77msf2 branch July 24, 2026 16:28
akarma-synetal pushed a commit to akarma-synetal/objectui that referenced this pull request Jul 25, 2026
…tui#2807) (objectstack-ai#2811)

The drawer's 'waiting on' chips now key their collapse by (name, group) using
the framework's pending_approver_groups: the same person filling two groups
stays two labeled chips (Dev Admin · finance / · legal), one group filled
twice collapses to a single chip with a count. Group renders as a muted
· <group> sub-tag. Degrades to plain dedupe + count when no group data present.

Rebased onto latest main (resolves overlap with the objectstack-ai#2810 admin-override
change in the same file).

Closes objectui#2807 (UI half)


Claude-Session: https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

审批人 chips 按组标注(会签 group 归属)— #2762 P1-2 后续

2 participants