Release 108: Mobile work in progress - #641
Draft
alichherawalla wants to merge 11 commits into
Draft
Conversation
Moves the phone sharing package to 192693de, where pressing Stop mid-transfer ends the share and the stopped entry no longer shows a live percentage.
Turning the lock on, changing it, turning it off, unlocking and opening the app all went through their own code, so the lock could disagree with the stored passphrase. Every one of those now sends its intent to the one shared owner. The second lock store and the old lock service are gone. The keychain and the lock setting are each behind a small port that decides nothing, and the tests reach the lock through that one owner.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP. Do not merge yet.
Summary:
Verification: