Skip to content

fix(projects): wait for cleanup before local deletion - #653

Draft
alichherawalla wants to merge 1 commit into
codex/f2-app-restartfrom
codex/f3-project-cleanup
Draft

fix(projects): wait for cleanup before local deletion#653
alichherawalla wants to merge 1 commit into
codex/f2-app-restartfrom
codex/f3-project-cleanup

Conversation

@alichherawalla

Copy link
Copy Markdown
Collaborator

Recovered outcome

A project and its chats stay available when Mobile cannot finish knowledge cleanup. Both project delete surfaces now show the refusal reason.

Scope

  • Await the Mobile RAG cleanup before removing project and chat links.
  • Return one typed delete outcome from the project store.
  • Keep the project and chats on cleanup failure.
  • Show the returned reason in the existing Mobile alert surface.

Passed checks

  • Live iOS Simulator flow: opened Code Review, confirmed deletion, returned to Projects, and verified that the project was absent.
  • Project store checks: 32 passed, including cleanup refusal preservation.
  • Focused ESLint passed.
  • Full Mobile TypeScript check passed after refreshing the ignored local Shared package output.
  • Diff checks passed.

Open gates

  • The iOS Release simulator build fails because the installed llama.rn package has no ios-arm64_x86_64-simulator XCFramework slice.
  • All available physical iPhones are offline, so physical-device proof is open.
  • The live cleanup-refusal state and visual inspection are open because this task prohibits Computer Use. Simulator screenshots were captured but not visually inspected.
  • No E2E tests were added, as requested.

This PR must remain draft while these required gates are open.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant