Skip to content

fix(tools): consume shared execution limits - #654

Draft
alichherawalla wants to merge 1 commit into
codex/f3-project-cleanupfrom
codex/f4-tool-execution
Draft

alichherawalla wants to merge 1 commit into
codex/f3-project-cleanupfrom
codex/f4-tool-execution

Conversation

@alichherawalla

Copy link
Copy Markdown
Collaborator

User outcome

A Mobile tool reply uses the same total call budget and result-size policy as Desktop. Successful tool data remains visible when the model final response is empty.

Scope

  • Consume Shared defaults and normalization in settings and both text engines.
  • Count a parallel batch against the total response allowance.
  • Bound JS and LiteRT tool results to the room left in the configured model window.
  • Preserve successful tool output after an empty JS final response.
  • Keep Mobile as a thin consumer. Exclude application migration, workflow machinery, compatibility paths, and unrelated model/RAG migration drift.

Passed checks

  • npx tsc --noEmit
  • Focused ESLint - zero errors
  • Focused Tool execution tests - 38/38 passed
  • Metro bundled the current branch and the installed Debug app launched on OGA-A1
  • git diff codex/f3-project-cleanup...HEAD --check

Open gates

  • The existing rendered Tool execution checks stop before the tool flow because the shared chat harness still looks for the removed model-item test ID. Behavioral UI proof remains open.
  • User-triggered live Tool execution and visual inspection remain open because Computer Use/CUA is prohibited.
  • No E2E tests were added or run, as requested.
  • The iOS Release simulator build remains blocked because installed llama.rn has no ios-arm64_x86_64-simulator XCFramework slice.
  • All listed physical iPhones are unavailable.
  • Production builds were not run because the live and behavioral UI gates are open.
  • The inherited Desktop stack still has existing Shared model/RAG type drift; f3 Desktop hosted CI failed there. f3 Mobile has no hosted CI check, and CodeRabbit passed or skipped because that PR is draft.

This PR must remain draft while these gates are open.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant