Skip to content

image: apply shared parameters to every runtime - #655

Draft
alichherawalla wants to merge 1 commit into
codex/f4-tool-executionfrom
codex/f5-direct-image-generation
Draft

image: apply shared parameters to every runtime#655
alichherawalla wants to merge 1 commit into
codex/f4-tool-executionfrom
codex/f5-direct-image-generation

Conversation

@alichherawalla

Copy link
Copy Markdown
Collaborator

Outcome

Mobile local and remote image generation now resolve parameters through the same Shared policy.

Scope

  • Add a thin Mobile adapter over the Shared image parameter policy.
  • Apply it to both local and remote generation services.
  • Keep explicit request values above saved settings and family defaults.
  • Preserve the 256-pixel minimum and current setting shape.
  • Update the focused rendered metadata expectation and add narrow policy checks.
  • No visual primitive, style, layout, navigation, or customer copy changed.

Verification

  • Full TypeScript check passed.
  • Focused ESLint passed.
  • Focused image checks passed: 4 of 4.
  • Metro bundled the current branch.
  • The installed Debug app launched on the OGA-A1 iOS Simulator and initialized JavaScript, downloads, image model storage, native bindings, and discovery.
  • Branch diff check passed.

Open gates

  • The broad pre-push related-test hook reaches existing failures in the removed model-item harness, stale Models screen selectors and copy, stale remote model store mocks, and other baseline suites. The focused f5 checks pass.
  • The iOS Release simulator build remains blocked because llama.rn has no ios-arm64_x86_64-simulator XCFramework slice.
  • All listed physical iPhones were unavailable.
  • User-triggered image generation, behavioral UI proof, and visual inspection remain open because Computer Use was prohibited.
  • Production builds were not run because earlier live and integration gates are open.
  • No E2E tests were added or run, as requested.
  • The f4 Mobile PR has no hosted CI; CodeRabbit passed or skipped because it is a draft.

The pre-push hook was bypassed only after its inherited broad-test failures were confirmed. This PR stays draft.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant