Add option for using bundled static hwloc by bratpiorka · Pull Request #1609 · oneapi-src/unified-memory-framework

bratpiorka · 2026-09-23T12:04:41Z

Add UMF_USE_BUNDLED_HWLOC option for using bundled static hwloc.

Copilot

Copilot review overview

🟡 Changes recommended

Critical issues remain in static installation/linking and Windows bundled-header configuration.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 3

Open (3)

Bundled hwloc archive missing from installed static UMF interface · New
Windows hwloc config omits HWLOC_WIN_SYS · New
Static hwloc config incorrectly applies __declspec(dllimport) · New

What changed in this PR

Adds UMF_USE_BUNDLED_HWLOC to use bundled static hwloc on Linux and Windows.

Changes:

Adds bundled hwloc headers and platform configurations.
Updates CMake integration, documentation, CI, and tooling exclusions.

File	Summary
`src/deps/hwloc/windows/include/hwloc/autogen/config.h`	Windows hwloc configuration.
`src/deps/hwloc/linux/include/hwloc/autogen/config.h`	Linux hwloc configuration.
`src/deps/hwloc/include/hwloc/shmem.h`	Bundled shared-memory topology API.
`src/deps/hwloc/include/hwloc/rsmi.h`	Bundled ROCm SMI API.
`src/deps/hwloc/include/hwloc/plugins.h`	Bundled plugin API.
`src/deps/hwloc/include/hwloc/openfabrics-verbs.h`	Bundled OpenFabrics API.
`src/deps/hwloc/include/hwloc/opencl.h`	Bundled OpenCL API.
`src/deps/hwloc/include/hwloc/nvml.h`	Bundled NVML API.
`src/deps/hwloc/include/hwloc/memattrs.h`	Bundled memory-attributes API.
`src/deps/hwloc/include/hwloc/linux.h`	Bundled Linux helpers.
`src/deps/hwloc/include/hwloc/linux-libnuma.h`	Bundled libnuma API.
`src/deps/hwloc/include/hwloc/levelzero.h`	Bundled Level Zero API.
`src/deps/hwloc/include/hwloc/inlines.h`	Bundled inline helpers.
`src/deps/hwloc/include/hwloc/glibc-sched.h`	Bundled glibc scheduling API.
`src/deps/hwloc/include/hwloc/gl.h`	Bundled OpenGL API.
`src/deps/hwloc/include/hwloc/export.h`	Bundled topology export API.
`src/deps/hwloc/include/hwloc/distances.h`	Bundled distances API.
`src/deps/hwloc/include/hwloc/diff.h`	Bundled topology-diff API.
`src/deps/hwloc/include/hwloc/deprecated.h`	Bundled compatibility API.
`src/deps/hwloc/include/hwloc/cudart.h`	Bundled CUDA runtime API.
`src/deps/hwloc/include/hwloc/cuda.h`	Bundled CUDA API.
`src/deps/hwloc/include/hwloc/cpukinds.h`	Bundled CPU-kind API.
`src/deps/hwloc/include/hwloc/bitmap.h`	Bundled bitmap API.
`scripts/check_license/file-exceptions.sh`	Excludes vendored files from license checks.
`README.md`	Documents the bundled hwloc option.
`CMakeLists.txt`	Configures bundled hwloc selection.
`.github/workflows/reusable_basic.yml`	Adds bundled hwloc CI coverage.
`.github/workflows/.spellcheck-conf.toml`	Excludes vendored files from spellchecking.
`.github/scripts/run-codespell.py`	Excludes vendored files from codespell checks.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🟡 Changes recommended

Critical portability, CMake compatibility, symbol-isolation, and consumer-target issues remain unresolved.

Review effort: Lite
Findings: 4

Open (4)

Linux archive is incompatible with non-x86-64 targets · New
Use CMake 3.14-compatible install prefix expression · New
Windows bundled hwloc symbols conflict with user hwloc · New
Use exported umf::headers target · New

Resolved since last review (3)

Static hwloc config incorrectly applies __declspec(dllimport)
Windows hwloc config omits HWLOC_WIN_SYS
Bundled hwloc archive missing from installed static UMF interface

+                               NAME)
+        set(UMF_LIBS
+            ${UMF_LIBS}
+            "$<INSTALL_INTERFACE:$<INSTALL_PREFIX>/${CMAKE_INSTALL_LIBDIR}/${UMF_HWLOC_ARCHIVE_NAME}>"


+find_package(umf REQUIRED CONFIG)
+
+add_executable(umf_install_consumer main.c)
+target_link_libraries(umf_install_consumer PRIVATE umf::umf umf::umf_headers)


+    - name: Build and install UMF
+      run: |
+        cmake --build ${{env.BUILD_DIR}} --config ${{matrix.build_type}} -j $Env:NUMBER_OF_PROCESSORS
+        cmake --install ${{env.BUILD_DIR}} --config ${{matrix.build_type}}


+    - name: Build and run test of installed UMF
+      run: |
+        $extraArgs = @()
+        $prefixPath = "${{env.INSTL_DIR}}"


Copilot

Copilot review overview

🟡 Changes recommended

Unresolved critical and moderate build, linkage, compatibility, and artifact-generation issues remain.

Review effort: Lite
Findings: 4

Open (4)

Propagate platform libraries required by bundled hwloc archive · New
Fix Windows build script path for Visual Studio archive output · New
Use exported umf::headers target
Use CMake 3.14-compatible install prefix expression

Resolved since last review (2)

Windows bundled hwloc symbols conflict with user hwloc
Linux archive is incompatible with non-x86-64 targets

+    add_library(${UMF_HWLOC_NAME} INTERFACE)
+    target_link_libraries(${UMF_HWLOC_NAME} INTERFACE "${LIBHWLOC_LIBRARIES}")
+    target_include_directories(${UMF_HWLOC_NAME}
+                               INTERFACE ${LIBHWLOC_INCLUDE_DIRS})


+        '-DCMAKE_STATIC_LINKER_FLAGS=/Brepro')
+    Invoke-Native cmake @('--build', $BuildDir, '--config', 'Release', '--parallel')
+
+    $lib = Join-Path $BuildDir 'Release\hwloc.lib'


bratpiorka force-pushed the rrudnick_static_hwloc branch 8 times, most recently from e6cfe87 to 757d81e Compare September 24, 2026 08:05

bratpiorka requested a lite review from Copilot September 24, 2026 13:14

Copilot started reviewing on behalf of bratpiorka September 24, 2026 13:15 View session

Copilot AI reviewed Sep 24, 2026

View reviewed changes

Comment thread CMakeLists.txt

Comment thread src/deps/hwloc/windows/include/hwloc/autogen/config.h Outdated

Comment thread src/deps/hwloc/windows/include/hwloc/autogen/config.h Outdated

bratpiorka force-pushed the rrudnick_static_hwloc branch from 757d81e to 0bbfa9d Compare September 24, 2026 13:23

github-advanced-security Bot found potential problems Sep 24, 2026

View reviewed changes

Comment thread .github/workflows/reusable_basic.yml Fixed

Comment thread .github/workflows/reusable_basic.yml Fixed

bratpiorka force-pushed the rrudnick_static_hwloc branch 4 times, most recently from 0a48623 to 4383652 Compare September 29, 2026 12:57

bratpiorka requested a lite review from Copilot September 29, 2026 13:09

Copilot started reviewing on behalf of bratpiorka September 29, 2026 13:10 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

bratpiorka force-pushed the rrudnick_static_hwloc branch 2 times, most recently from 9159115 to b03d490 Compare September 29, 2026 15:41

github-advanced-security Bot found potential problems Sep 29, 2026

View reviewed changes

bratpiorka force-pushed the rrudnick_static_hwloc branch 2 times, most recently from d4dc15d to 2aeb614 Compare September 29, 2026 16:15

bratpiorka added 4 commits September 29, 2026 17:16

Add hwloc headers and static libs

bd3b330

Add CMake uption for using bundled hwloc

feb52dc

Test bundled hwloc in CI

48a1f9c

Exclude src/deps from code checks

47eed2b

Add test for UMF w static HWLOC

2aeb614

bratpiorka requested a lite review from Copilot September 29, 2026 17:42

Copilot started reviewing on behalf of bratpiorka September 29, 2026 17:42 View session

bratpiorka force-pushed the rrudnick_static_hwloc branch from 9d06f8a to 4b61f8a Compare September 29, 2026 17:50

Copilot AI reviewed Sep 29, 2026

View reviewed changes

bratpiorka force-pushed the rrudnick_static_hwloc branch 2 times, most recently from 4b61f8a to 5293fcc Compare October 1, 2026 09:10

x

5293fcc

Navigation Menu

Add option for using bundled static hwloc - #1609

Add option for using bundled static hwloc#1609
bratpiorka wants to merge 6 commits into
oneapi-src:mainfrom
bratpiorka:rrudnick_static_hwloc

bratpiorka commented Sep 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bratpiorka commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bratpiorka commented Sep 23, 2026 •

edited

Loading