validate: image picker - #792
Merged
Merged
Conversation
- @vxrn/native/image-picker: One.ImagePicker.launchLibrary/launchCamera/ getCameraPermissions/requestCameraPermissions with the expo reference shape - ios OneNativeImagePicker (PHPicker + camera, cache copies, permission reads) - android OneNativeImagePickerModule (system picker + document fallback, camera intent with FileProvider) + package registration - canonical native.app manifest in @vxrn/utils; one + vxrn re-export it; new native.app imagePicker.camera stamped to Info.plist + AndroidManifest - fixture, ios conformance suite, android leg, docs, unit tests
…guarded camera intent
- launchLibrary takes the single options map the js contract and ios use - OneNativeFileProvider subclass so the manifest merges by our own name - scope the native lib cmake abis to reactNativeArchitectures so the single-abi build links against the same worklets prefab the app uses Team-Machine-Session: m16066
Team-Machine-Session: m16066
- unit tests match the guard-free surface: sync throws from the launches, sync validation through the native and web namespaces, throw-on-no-match for both prebuild camera replaces - docs read granted for the web permission calls - conformance drives the picker by calibrated points: the picker publishes no accessibility tree, so presentation waits read the bare application node and the close and first-cell taps are frame-guarded coordinates; the metadata wait proves each tap - fix the heic seed url (../assets, not ../../assets) and tighten the picked file suffix to the observed .jpeg - drop the unused png fixture and its gitignore exception
…l leg - clear whichever documentsui package the device reports before the library tap; a remembered location flaked the cancel leg once
Keep both sides: slice G clipboard/network/browser plus the image picker slice. Every native module registered, every subpath export and One namespace member kept, docs sections and platform table rows united, all four conformance suites present. The image-picker react-native export follows the v2-beta dist rule the packaging test guards; native types regenerated, which drops two orphaned slice G declarations and one stale union member.
Keep both sides: scene lifecycle plus haptics/crypto/app-info on top of the image picker slice. The scene template and stamping survive the PrebuildAppConfig move to @vxrn/utils; the canonical manifest absorbs buildNumber/versionCode so validatePrebuildApp covers every validation either side had. Every native module registered, every subpath export and One member kept, docs sections and platform rows united, all conformance suites and runner legs present.
Collaborator
Author
|
landed on v2-beta as c0836e8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validation run for landing one-native-image-picker on v2-beta; fast-forwarded when green.