refactor(mcp): use typed slices helpers for contract ordering - #2359
Open
zjuzhongwen wants to merge 1 commit into
Open
refactor(mcp): use typed slices helpers for contract ordering#2359zjuzhongwen wants to merge 1 commit into
zjuzhongwen wants to merge 1 commit into
Conversation
zjuzhongwen
requested review from
Kay-Zee,
bjartek,
chasefleming,
janezpodhostnik,
jribbink,
mfbz and
nvdtf
as code owners
August 25, 2026 05:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace reflection-based sorting in the MCP contract tools with typed
slices.SortFuncandslices.Sort. The comparison keys and ascending order are unchanged, preserving deterministic tool output while simplifying the implementation.Files most relevant to review:
internal/mcp/tools.goTesting:
SKIP_NETWORK_TESTS=1 go test ./internal/mcpwith the CGO flags required by the repository.For contributor use:
masterbranchFiles changedin the Github PR explorer