Conversation
Signed-off-by: Jeremy Andrews <jandrews@venturseed.com>
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds beta Dart client SDK documentation and catalog metadata. It updates server Dart SDK documentation, repository references, package paths, and release data for the unified repository and version 0.0.24. ChangesDart SDK updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The beta client documentation and catalog metadata align with the published packages, and the server release data matches version 0.0.24. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
The Dart repository was renamed to
open-feature/dart-sdk, while the website still fetched its old root README, advertised server 0.0.23, and said the client SDK was unpublished. Fetch each SDK's package README from the renamed monorepo, refresh server documentation/compatibility data to 0.0.24, and add a discoverable Dart client-beta guide for the published 0.0.1-beta.1 package.The client is explicitly beta and excluded from the support matrix until conformance is complete. Package names, Dart imports, SDK minimums, and unrelated SDK matrix entries are preserved. Client README clarification and canonical link updates are also submitted in open-feature/dart-sdk#173; coordinate that source update so later regeneration retains the revised wording. The server guide was generated from the current main package README; client content includes the documentation-only README corrections from #173.
Validation: production Docusaurus build and targeted dataset ESLint pass. The initial build failed identically on unchanged upstream because this Windows session exports
DEBUG=release; removing only that variable from the build child process resolves the build, without changing source or machine settings. Standalone TypeScript checking reports existing upstream errors (missing module/assets, C++ dataset entry, and search-client types); these also reproduce on unchanged main. No validation or branch protection was disabled.Signed-off-by: ABC2015 6826984+ABC2015@users.noreply.github.com