chore: resolve open dependabot security alerts - #8
Conversation
- js-yaml <3.15.0 -> 3.15.0 via npm overrides on @istanbuljs/load-nyc-config (medium, alert #66) - js-yaml >=4.0.0,<=4.1.1 -> 4.2.0+ via npm overrides on @expo/xcpretty (medium, alert #65) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesDependency override updates
Estimated code review effort: 2 (Simple) | ~10 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR addresses Dependabot-reported security vulnerabilities in transitive js-yaml dependencies by adding targeted npm overrides, ensuring patched js-yaml versions are selected without broadly upgrading parent toolchain packages.
Changes:
- Added scoped npm
overridesto force patchedjs-yamlversions for@istanbuljs/load-nyc-configand@expo/xcpretty. - Updated
package-lock.jsonto reflect resolved patched versions (js-yaml@3.15.0andjs-yaml@4.3.0).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Adds scoped overrides to pin vulnerable transitive js-yaml paths to patched ranges. |
| package-lock.json | Updates the lockfile to reflect the patched js-yaml resolutions (3.15.0 and 4.3.0). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- shell-quote ^1.8.4 -> ^1.9.0 via override (high, alert #68) - brace-expansion scoped override to ^5.0.7 for @expo/fingerprint -> minimatch path (high, alert #67) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Summary
overridesto the specific dependency paths pulling in vulnerable versions.Dependabot Alerts Resolved
shell-quote(<= 1.8.4)^1.8.4to^1.9.0brace-expansion(>= 3.0.0, < 5.0.7, via@expo/fingerprint->minimatch@10.2.5)^5.0.7for that path onlyjs-yaml(< 3.15.0, via@istanbuljs/load-nyc-config->babel-plugin-istanbul->babel-jest->react-native)^3.15.0js-yaml(>= 4.0.0, <= 4.1.1, via@expo/xcpretty->@expo/cli->expo)^4.2.0The
brace-expansionoverride is scoped to the@expo/fingerprint->minimatchpath only, since otherminimatch@3.xconsumers (viababel-plugin-istanbul/glob) resolvebrace-expansion@1.1.14, which is outside the vulnerable range (>= 3.0.0) and unaffected by this advisory.This repo has no
test/lint/buildscripts and no CI workflows;npm installconfirms all four packages resolve to patched versions, andnpx tsc --noEmitpasses with no errors.