Skip to content

fix: use pathToFileURL for plugin entry import to support Windows paths #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nivesh353 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use pathToFileURL for plugin entry import to support Windows paths #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { readFile, readdir, stat, mkdir, rm } from "fs/promises";
import { join } from "path";
import { pathToFileURL } from "url";
import { execFileSync } from "child_process";
import { createRequire } from "module";
import { homedir } from "os";
Expand Down Expand Up @@ -242,7 +243,11 @@ async function loadPlugin(
const { createPluginApi } = await import("./plugin-sdk.js");
const api = createPluginApi(manifest.id, pluginDir, config);
const entryPath = join(pluginDir, manifest.entry);
const mod = await import(entryPath);
// Node's ESM loader requires a file:// URL for absolute paths on
// Windows — a raw "D:\..." path is misread as a URL with protocol
// "d:", which the loader rejects. pathToFileURL() handles this
// correctly on every OS, including plain POSIX paths.
const mod = await import(pathToFileURL(entryPath).href);
if (typeof mod.register === "function") {
await mod.register(api);
} else if (typeof mod.default === "function") {
Expand Down