Fixes 30711: default data contracts to draft status by PRADDZY · Pull Request #30833 · open-metadata/OpenMetadata

PRADDZY · 2026-08-02T22:30:39Z

Describe your changes:

Data contract creation now defaults new contracts to Draft instead of hardcoding Approved. The contract details step also exposes the status field so users can choose Draft, In Review, or Approved before saving.

Type of change:

Bug fix

High-level design:

N/A - small bug fix.

Tests:

Use cases covered

Creating a data contract without selecting a status sends Draft.
Creating a data contract after selecting In Review preserves the selected status.
Contract detail form renders the status selector with Draft, In Review, and Approved options.

Unit tests

I added unit tests for the new/changed logic.
Files added/updated:
- openmetadata-ui/src/main/resources/ui/src/components/DataContract/AddDataContract/AddDataContract.test.tsx
- openmetadata-ui/src/main/resources/ui/src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.test.tsx
Coverage %: Not measured; focused Jest coverage was not run.

Backend integration tests

Not applicable (no backend API changes).

Ingestion integration tests

Not applicable (no ingestion changes).

Playwright (UI) tests

Not added; covered by focused component tests for this form behavior.

Manual testing performed

corepack yarn test --runInBand src/components/DataContract/AddDataContract/AddDataContract.test.tsx src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.test.tsx
.\\node_modules\\.bin\\eslint.cmd --no-error-on-unmatched-pattern src/components/DataContract/AddDataContract/AddDataContract.tsx src/components/DataContract/AddDataContract/AddDataContract.test.tsx src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.tsx src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.test.tsx
.\\node_modules\\.bin\\prettier.cmd --config .\\.prettierrc.yaml --ignore-path .\\.prettierignore src/components/DataContract/AddDataContract/AddDataContract.tsx src/components/DataContract/AddDataContract/AddDataContract.test.tsx src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.tsx src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.test.tsx --check

UI screen recording / screenshots:

Not attached; the status behavior is covered by focused component tests.

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
My PR is linked to a GitHub issue via Fixes #<issue-number> above.
No hard-to-understand code paths were added that require extra comments.
Not applicable: no JSON Schema changes.
For UI changes: I attached a screen recording and/or screenshots above.
I have added tests (unit / integration / Playwright as applicable) and listed them above.

I have added a test that covers the exact scenario we are fixing.

Greptile Summary

The PR changes new data contracts to default to Draft and exposes the lifecycle status in the contract details form.

Uses the selected status when creating a contract, falling back to Draft.
Adds Draft, In Review, and Approved options to the details form.
Updates component tests for default and explicitly selected statuses.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
openmetadata-ui/src/main/resources/ui/src/components/DataContract/AddDataContract/AddDataContract.tsx	Creation now submits the selected entity status and defaults an absent value to Draft.
openmetadata-ui/src/main/resources/ui/src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.tsx	Adds a translated lifecycle-status selector initialized from the contract or Draft.
openmetadata-ui/src/main/resources/ui/src/components/DataContract/AddDataContract/AddDataContract.test.tsx	Updates creation expectations and verifies that an explicitly selected status is submitted.
openmetadata-ui/src/main/resources/ui/src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.test.tsx	Verifies the status field configuration and available lifecycle options.

_{Reviews (2): Last reviewed commit: "fix: localize data contract status optio..." | Re-trigger Greptile}

github-actions · 2026-08-02T22:30:48Z

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

Issue Data Contracts created via the UI are always set to Approved, bypassing Draft/review workflow #30711 is missing Shipping → Source.
Issue Data Contracts created via the UI are always set to Approved, bypassing Draft/review workflow #30711 is missing Shipping → Priority.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

github-actions · 2026-08-02T22:30:57Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copilot

Pull request overview

This PR fixes the Data Contract creation flow in the UI so newly created contracts default to Draft (instead of being hardcoded to Approved) and exposes a Status selector in the contract details step, aligning the UI with the entityStatus governance workflow.

Changes:

Default createContract payload entityStatus to Draft unless the user explicitly selects a different status.
Add an entityStatus select field to the Contract Details form tab (Draft / In Review / Approved).
Update and extend component tests to cover the defaulting behavior and preserving a user-selected status.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
openmetadata-ui/src/main/resources/ui/src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.tsx	Adds a Status selector to the contract details form and defaults it to Draft.
openmetadata-ui/src/main/resources/ui/src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.test.tsx	Extends tests to assert the Status field is rendered and wired via generated form fields.
openmetadata-ui/src/main/resources/ui/src/components/DataContract/AddDataContract/AddDataContract.tsx	Removes hardcoded Approved status and defaults entityStatus to Draft when creating a contract.
openmetadata-ui/src/main/resources/ui/src/components/DataContract/AddDataContract/AddDataContract.test.tsx	Updates createContract expectations and adds a test ensuring a selected status is preserved.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-08-28T16:50:46Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions · 2026-08-28T17:08:50Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	70.5% (95308/135182)	55.03% (56386/102460)	56.4% (18825/33375)

ShaileshParmar11 · 2026-08-29T08:21:28Z

Hi @PRADDZY UI check style is failing can you please take a look?

ShaileshParmar11 · 2026-08-31T05:59:54Z

Hi @PRADDZY UI check style is failing can you please take a look?

Let me know once you are done with this @PRADDZY

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

PRADDZY · 2026-08-31T08:16:14Z

@ShaileshParmar11 Pushed the UI checkstyle/status-label updates; checks are rerunning.

github-actions · 2026-08-31T08:16:21Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

…opdown getByRole('option') doesn't resolve against Ant Design's dropdown portal in CI, causing a 5-minute hang until the test timeout kills the browser. Mirror the established pattern for SLA selects: add popupClassName='contract-status-dropdown' to the status Select in ContractDetailFormTab so the dropdown popup is scopeable, then use .contract-status-dropdown [title="Approved"] in the E2E helper. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

github-actions · 2026-09-08T05:37:40Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

github-actions · 2026-09-09T02:48:04Z

🚦 Removed from the merge queue — `failed_checks` (2026-09-09T02:47:53Z)

Blocked the queue: playwright-summary

Postgresql PR Playwright E2E Tests — playwright-summary, playwright / playwright-ci (chromium-07)

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

github-actions · 2026-09-09T08:25:01Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

github-actions · 2026-09-09T12:12:13Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

github-actions · 2026-09-09T13:17:06Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

gitar-bot · 2026-09-09T13:17:23Z

Code Review ✅ Approved

Data contracts now default to Draft status on creation, with the contract details form exposing the lifecycle status selector to allow users to choose Draft, In Review, or Approved before saving. Component tests verify both the default Draft behavior and explicit status selection. No issues found.

Options

Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source}

github-actions · 2026-09-09T13:24:03Z

⚠️ UI Checkstyle passed — lint findings in changed files

🔍 ESLint findings in this PR's files — 0 error(s), 4 warning(s)

Errors block the build. Warnings do not yet — they are rules whose backlog is still
being worked down, listed so this PR does not add to it. See docs/ui-code-quality-gate.md.

0 error(s), 4 warning(s) across 2 changed file(s).

Count	Rule
4	`react-hooks/exhaustive-deps`

All findings

	Location	Rule	Message
🟡	`src/components/DataContract/AddDataContract/AddDataContract.tsx:303:6`	`react-hooks/exhaustive-deps`	React Hook useCallback has missing dependencies: 'onSave' and 't'. Either include them or remove the dependency array. If 'onSave' changes too often, find the p
🟡	`src/components/DataContract/AddDataContract/AddDataContract.tsx:518:6`	`react-hooks/exhaustive-deps`	React Hook useMemo has a missing dependency: 't'. Either include it or remove the dependency array.
🟡	`src/components/DataContract/AddDataContract/AddDataContract.tsx:561:6`	`react-hooks/exhaustive-deps`	React Hook useMemo has a missing dependency: 't'. Either include it or remove the dependency array.
🟡	`src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.tsx:142:6`	`react-hooks/exhaustive-deps`	React Hook useEffect has a missing dependency: 'form'. Either include it or remove the dependency array.

Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed

sonarqubecloud · 2026-09-09T13:40:20Z

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PRADDZY requested a review from a team as a code owner August 2, 2026 22:30

Copilot AI lite review requested due to automatic review settings August 2, 2026 22:30

Copilot started reviewing on behalf of PRADDZY August 2, 2026 22:31 View session

Copilot AI reviewed Aug 2, 2026

View reviewed changes

Comment thread ...ain/resources/ui/src/components/DataContract/ContractDetailFormTab/ContractDetailFormTab.tsx Outdated

Comment thread ...i/src/main/resources/ui/src/components/DataContract/AddDataContract/AddDataContract.test.tsx Outdated

TeddyCr requested review from ShaileshParmar11, chirag-madlani and karanh37 as code owners August 28, 2026 16:50

Copilot AI review requested due to automatic review settings August 28, 2026 16:50

Copilot AI reviewed Aug 28, 2026

TeddyCr added the safe to test Add this label to run secure Github workflows on PRs label Aug 28, 2026

TeddyCr enabled auto-merge August 28, 2026 16:51

TeddyCr mentioned this pull request Aug 28, 2026

Fixes 30711: Data Contracts created via the UI are always set to Approved, bypassing Draft/review workflow #31843

Closed

13 tasks

PRADDZY and others added 3 commits August 31, 2026 13:21

fix: default data contracts to draft status

77ee168

Apply batched suggestions from code review

56b443d

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix: localize data contract status options

09bb37e

auto-merge was automatically disabled August 31, 2026 08:16
Head branch was pushed to by a user without write access

PRADDZY force-pushed the fix/data-contract-default-status branch from df024b2 to 09bb37e Compare August 31, 2026 08:16

Copilot AI review requested due to automatic review settings August 31, 2026 08:16

Copilot AI reviewed Aug 31, 2026

github-actions Bot removed the safe to test Add this label to run secure Github workflows on PRs label Aug 31, 2026

ShaileshParmar11 added the safe to test Add this label to run secure Github workflows on PRs label Sep 1, 2026

ShaileshParmar11 temporarily deployed to test September 1, 2026 10:34 — with GitHub Actions Inactive

shrabantipaul-collate temporarily deployed to test September 8, 2026 04:48 — with GitHub Actions Inactive

shrabantipaul-collate had a problem deploying to test September 8, 2026 04:48 — with GitHub Actions Failure

shrabantipaul-collate temporarily deployed to test September 8, 2026 04:48 — with GitHub Actions Inactive

shrabantipaul-collate dismissed chirag-madlani’s stale review via d1763bb September 8, 2026 05:37

Copilot AI review requested due to automatic review settings September 8, 2026 05:37

Copilot AI reviewed Sep 8, 2026

Merge branch 'main' into fix/data-contract-default-status

1516431

Copilot AI reviewed Sep 8, 2026

chirag-madlani approved these changes Sep 8, 2026

View reviewed changes

Merge branch 'main' into fix/data-contract-default-status

a268be3

Copilot AI reviewed Sep 9, 2026

Merge branch 'main' into fix/data-contract-default-status

a48b6b7

Copilot AI reviewed Sep 9, 2026

Merge branch 'main' into fix/data-contract-default-status

b97b7d9

Copilot AI reviewed Sep 9, 2026

Uh oh!

Conversation

PRADDZY commented Aug 2, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Type of change:

High-level design:

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Checklist:

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

github-actions Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ PR checklist incomplete

Uh oh!

github-actions Bot commented Aug 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 28, 2026

Uh oh!

github-actions Bot commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jest test Coverage

UI tests summary

Uh oh!

ShaileshParmar11 commented Aug 29, 2026

Uh oh!

ShaileshParmar11 commented Aug 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

PRADDZY commented Aug 31, 2026

Uh oh!

github-actions Bot commented Aug 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 9, 2026

🚦 Removed from the merge queue — failed_checks (2026-09-09T02:47:53Z)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

PRADDZY commented Aug 2, 2026 •

edited by greptile-apps Bot

Loading

github-actions Bot commented Aug 2, 2026 •

edited

Loading

github-actions Bot commented Aug 28, 2026 •

edited

Loading

🚦 Removed from the merge queue — `failed_checks` (2026-09-09T02:47:53Z)

gitar-bot Bot commented Sep 9, 2026 •

edited

Loading