fix(security): bump stream-json 1.7.5 → 3.5.0 (backport 2.0 #33008) - #33018
Conversation
GHSA-528h-pc64-c93x (DoS). quicktype@20 pins 1.7.5; the repo only uses `quicktype -s schema` (json2ts.sh / json2ts-generate-all.sh), verified working with 3.5.0. Backport of the stream-json part of #33008; the js-yaml (tooling/antd-codemods) and vitest/svgo (ui-core-components) parts don't apply — those deps don't exist on 2.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
✅ Playwright Results — workflow succeededValidated commit ✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 57m 36s ⏱️ Max setup 2m 53s · max shard execution 17m 39s · max shard-job elapsed before upload 20m 48s · reporting 3s 🌐 205.27 requests/attempt · 2.82 app boots/UI scenario · 9.92% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Review feedback on #33018: the override jumps two majors past quicktype's exact pin, so record the verified-safe usage (schema mode only) and the re-verification duty on future quicktype upgrades. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Code Review ✅ Approved 1 resolved / 1 findingsBumps stream-json from 1.7.5 to 3.5.0 via forced resolution to address a DoS vulnerability (GHSA-528h-pc64-c93x). The resolution override bypasses the pinned range constraint, and yarn install and quicktype codegen have been verified to work correctly. No issues found. ✅ 1 resolved✅ Quality: Forced resolution jumps stream-json two majors past pinned range
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Backport of #33008 to
2.0— stream-json part only.Applied: stream-json 1.7.5 → 3.5.0 via root
resolutions(GHSA-528h-pc64-c93x, O(depth²) DoS). Verified on this branch:yarn installclean,quicktype -s schemacodegen works (the only quicktype mode this repo uses).Not applicable on 2.0: the other #33008 bumps target deps that don't exist on this branch —
tooling/antd-codemods(js-yaml) is absent, andui-core-componentshas no vitest/svgo.🤖 Generated with Claude Code