Skip to content

[CI] Run the ext_http component install test on Windows - #4326

Merged
dbarker merged 1 commit into
open-telemetry:mainfrom
thc1006:fix/windows-install-test-ext-http-component
Aug 1, 2026
Merged

[CI] Run the ext_http component install test on Windows#4326
dbarker merged 1 commit into
open-telemetry:mainfrom
thc1006:fix/windows-install-test-ext-http-component

Conversation

@thc1006

@thc1006 thc1006 commented Aug 1, 2026

Copy link
Copy Markdown
Member

Split out of #4315, which @dbarker asked to take separately.

The Windows cmake.install.test component list in ci/do_ci.ps1 contains ext_http_curl but not ext_http, so install/test/cmake/component_tests/ext_http is never configured or built on Windows. The component is installed there, since WITH_HTTP_CLIENT_CURL is on whenever an HTTP exporter is enabled and that is what creates the opentelemetry_http_client target, so this was a gap in the list rather than a component that does not exist on the platform.

With this, test_ext_http.cc compiles against the installed package on Windows the way it already does on Linux and macOS.

@thc1006
thc1006 requested a review from a team as a code owner August 1, 2026 10:54
The Windows cmake.install.test component list has ext_http_curl but not
ext_http, so install/test/cmake/component_tests/ext_http was never configured
or built there. The component is installed on Windows, since curl is enabled
whenever an HTTP exporter is, so this was a gap in the list rather than a
component that does not exist.

Split out of open-telemetry#4315.
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (59dcd5b) to head (89dbf15).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4326   +/-   ##
=======================================
  Coverage   81.20%   81.20%           
=======================================
  Files         446      446           
  Lines       18963    18963           
=======================================
  Hits        15397    15397           
  Misses       3566     3566           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ThomsonTan ThomsonTan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably change the title to [CI] instead of [BUILD].

@dbarker dbarker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@dbarker dbarker changed the title [BUILD] Run the ext_http component install test on Windows [CI] Run the ext_http component install test on Windows Aug 1, 2026
@dbarker
dbarker merged commit 7a4da94 into open-telemetry:main Aug 1, 2026
72 checks passed
@thc1006
thc1006 deleted the fix/windows-install-test-ext-http-component branch August 1, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants