Skip to content

feat: support COMPATIBLE_TLS connectionSpec in OkHttpHttpSender#8594

Draft
singhlovepreet9 wants to merge 3 commits into
open-telemetry:mainfrom
singhlovepreet9:feat/okhttp-compatible-tls
Draft

feat: support COMPATIBLE_TLS connectionSpec in OkHttpHttpSender#8594
singhlovepreet9 wants to merge 3 commits into
open-telemetry:mainfrom
singhlovepreet9:feat/okhttp-compatible-tls

Conversation

@singhlovepreet9

Copy link
Copy Markdown

Fixes #7573.

This PR adds ConnectionSpec.COMPATIBLE_TLS to the OkHttpClient.Builder's connectionSpecs for HTTPS endpoints, enabling support for legacy systems like WebSphere 8.x / IBM J9 Java 1.8 that cannot satisfy the requirements of MODERN_TLS.

By configuring OkHttpHttpSender to fall back to COMPATIBLE_TLS when MODERN_TLS is unavailable, we maintain the highest possible level of security while unblocking telemetry exports on older JVMs.

@singhlovepreet9
singhlovepreet9 requested a review from a team as a code owner July 12, 2026 18:28
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 12, 2026

Copy link
Copy Markdown

CLA Not Signed

@jack-berg

Copy link
Copy Markdown
Member

Hey I gave this issue some thought and shared my analysis here: #7573 (comment)

I think we should go in a different direction with this: #8610, which embodies option d in the comment.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 18, 2026

Copy link
Copy Markdown

Pull request dashboard status

  • Waiting on: Author
  • Next step: Move out of draft to request review.

@singhlovepreet9
singhlovepreet9 force-pushed the feat/okhttp-compatible-tls branch from 253ebda to 1439a69 Compare July 18, 2026 13:59
@otelbot otelbot Bot added the api-change Changes to public API surface area label Jul 18, 2026
@otelbot

otelbot Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

⚠️ API changes detected — additional maintainer review required

@jack-berg @jkwatson

This PR modifies the public API surface area of the following module(s):

  • opentelemetry-exporter-otlp
  • opentelemetry-sdk-common

Please review the changes in docs/apidiffs/current_vs_latest/ carefully before approving.

@singhlovepreet9
singhlovepreet9 marked this pull request as draft July 18, 2026 14:06
@singhlovepreet9
singhlovepreet9 force-pushed the feat/okhttp-compatible-tls branch from 1439a69 to 515d117 Compare July 18, 2026 15:35
@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.64%. Comparing base (09d6c17) to head (515d117).

Files with missing lines Patch % Lines
...ry/exporter/sender/jdk/internal/JdkHttpSender.java 80.00% 0 Missing and 1 partial ⚠️
...orter/sender/okhttp/internal/OkHttpGrpcSender.java 87.50% 0 Missing and 1 partial ⚠️
...orter/sender/okhttp/internal/OkHttpHttpSender.java 93.75% 0 Missing and 1 partial ⚠️
...ntelemetry/sdk/common/export/HttpSenderConfig.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8594   +/-   ##
=========================================
  Coverage     91.64%   91.64%           
- Complexity    10348    10372   +24     
=========================================
  Files          1013     1013           
  Lines         27380    27441   +61     
  Branches       3218     3230   +12     
=========================================
+ Hits          25092    25149   +57     
- Misses         1558     1559    +1     
- Partials        730      733    +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to public API surface area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OkHttpHttpSender should support COMPATIBLE_TLS connectionSpec

2 participants