Replace jsonschema2pojo with hand rolled version#8600
Open
jack-berg wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (78.10%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8600 +/- ##
============================================
- Coverage 91.62% 91.62% -0.01%
- Complexity 10321 10361 +40
============================================
Files 1013 1021 +8
Lines 27287 27285 -2
Branches 3203 3203
============================================
- Hits 25001 24999 -2
Misses 1559 1559
Partials 727 727 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've recently made a handful of changes to heavily customize the behavior of jsonschema2pojo. Along the way, I started increasingly feeling like I was working against the currents - jumping through hoops to get the output I wanted. And I've been wondering what it would look like to rip out jsonschema2pojo in favor of hand rolling.
This PR does just that.
Its faithfully recreates the generated output of jsonschema2pojo with just a few exceptions:
@Generated("jsonschema2pojo")to@Generated("io.opentelemetry.gradle.DeclarativeConfigPojoGenerator")*Modelsuffix