feat: stabilize ServiceInstanceIdResourceProvider by moving to autoco… - #8770
Open
Rajkaran-122 wants to merge 3 commits into
Open
feat: stabilize ServiceInstanceIdResourceProvider by moving to autoco…#8770Rajkaran-122 wants to merge 3 commits into
Rajkaran-122 wants to merge 3 commits into
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-09-03 19:37 UTC Investigate required status check failures. Status above doesn't look right?
|
…nfigure Move ServiceInstanceIdResourceProvider from incubator to stable autoconfigure module to align with the now-stable service.instance.id semantic convention. Changes: - Add ServiceInstanceIdResourceProvider to autoconfigure module with @SInCE 1.47.0 - Register provider in META-INF/services for autoconfigure SPI discovery - Deprecate incubator ServiceInstanceIdResourceProvider with migration guidance - Update existing tests to accommodate new stable provider behavior - Add comprehensive test coverage for stable provider - Update EnvironmentResourceProvider documentation for provider ordering - Add changelog entry for this stabilization Backward compatibility: - Incubator provider remains functional but deprecated - Existing autoconfigure users automatically get stable provider - Users can override service.instance.id via configuration - Provider order maintained (runs after EnvironmentResourceProvider) Resolves open-telemetry#8410
Rajkaran-122
force-pushed
the
issue-8410-stabilize-service-instance-id
branch
from
September 3, 2026 10:59
e226ef0 to
ae2c861
Compare
Contributor
Author
|
@jack-berg sir , PTAL. |
jack-berg
reviewed
Sep 9, 2026
jack-berg
reviewed
Sep 9, 2026
jack-berg
reviewed
Sep 9, 2026
jack-berg
reviewed
Sep 9, 2026
jack-berg
reviewed
Sep 9, 2026
…xtending internal interface Changes: - Moved ServiceInstanceIdResourceProvider to internal package (io.opentelemetry.sdk.autoconfigure.internal) - Kept ConditionalResourceProvider in internal package as designed - ServiceInstanceIdResourceProvider now implements both public ResourceProvider and internal ConditionalResourceProvider - Removed redundant incubator provider implementation - Updated SPI registration to point to internal provider - Fixed all import statements to use internal ConditionalResourceProvider - Updated tests to match internal package structure - Removed manual CHANGELOG entry (maintained by release process) - Removed unrelated test assertions from ResourceConfigurationTest This approach addresses the maintainer's comment about not having a public API extend an internal interface by keeping the provider internal while maintaining all required conditional behavior.
Rajkaran-122
force-pushed
the
issue-8410-stabilize-service-instance-id
branch
from
September 9, 2026 20:47
439332e to
4fe6d42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ServiceInstanceIdResourceProvider from incubator to stable autoconfigure module to align with the now-stable service.instance.id semantic convention.
Changes:
Backward compatibility:
Resolves #8410