Skip to content

feat: stabilize ServiceInstanceIdResourceProvider by moving to autoco… - #8770

Open
Rajkaran-122 wants to merge 3 commits into
open-telemetry:mainfrom
Rajkaran-122:issue-8410-stabilize-service-instance-id
Open

feat: stabilize ServiceInstanceIdResourceProvider by moving to autoco…#8770
Rajkaran-122 wants to merge 3 commits into
open-telemetry:mainfrom
Rajkaran-122:issue-8410-stabilize-service-instance-id

Conversation

@Rajkaran-122

@Rajkaran-122 Rajkaran-122 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Move ServiceInstanceIdResourceProvider from incubator to stable autoconfigure module to align with the now-stable service.instance.id semantic convention.

Changes:

  • Add ServiceInstanceIdResourceProvider to autoconfigure module with @SInCE 1.47.0
  • Register provider in META-INF/services for autoconfigure SPI discovery
  • Deprecate incubator ServiceInstanceIdResourceProvider with migration guidance
  • Update existing tests to accommodate new stable provider behavior
  • Add comprehensive test coverage for stable provider
  • Update EnvironmentResourceProvider documentation for provider ordering
  • Add changelog entry for this stabilization

Backward compatibility:

  • Incubator provider remains functional but deprecated
  • Existing autoconfigure users automatically get stable provider
  • Users can override service.instance.id via configuration
  • Provider order maintained (runs after EnvironmentResourceProvider)

Resolves #8410

@Rajkaran-122
Rajkaran-122 requested a review from a team as a code owner September 2, 2026 21:51
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Sep 2, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-09-03 19:37 UTC

Investigate required status check failures.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
  • Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

…nfigure

Move ServiceInstanceIdResourceProvider from incubator to stable autoconfigure module
to align with the now-stable service.instance.id semantic convention.

Changes:
- Add ServiceInstanceIdResourceProvider to autoconfigure module with @SInCE 1.47.0
- Register provider in META-INF/services for autoconfigure SPI discovery
- Deprecate incubator ServiceInstanceIdResourceProvider with migration guidance
- Update existing tests to accommodate new stable provider behavior
- Add comprehensive test coverage for stable provider
- Update EnvironmentResourceProvider documentation for provider ordering
- Add changelog entry for this stabilization

Backward compatibility:
- Incubator provider remains functional but deprecated
- Existing autoconfigure users automatically get stable provider
- Users can override service.instance.id via configuration
- Provider order maintained (runs after EnvironmentResourceProvider)

Resolves open-telemetry#8410
@Rajkaran-122
Rajkaran-122 force-pushed the issue-8410-stabilize-service-instance-id branch from e226ef0 to ae2c861 Compare September 3, 2026 10:59
@Rajkaran-122

Copy link
Copy Markdown
Contributor Author

@jack-berg sir , PTAL.

Comment thread CHANGELOG.md Outdated
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 9, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

…xtending internal interface

Changes:
- Moved ServiceInstanceIdResourceProvider to internal package (io.opentelemetry.sdk.autoconfigure.internal)
- Kept ConditionalResourceProvider in internal package as designed
- ServiceInstanceIdResourceProvider now implements both public ResourceProvider and internal ConditionalResourceProvider
- Removed redundant incubator provider implementation
- Updated SPI registration to point to internal provider
- Fixed all import statements to use internal ConditionalResourceProvider
- Updated tests to match internal package structure
- Removed manual CHANGELOG entry (maintained by release process)
- Removed unrelated test assertions from ResourceConfigurationTest

This approach addresses the maintainer's comment about not having a public API extend an internal interface by keeping the provider internal while maintaining all required conditional behavior.
@Rajkaran-122
Rajkaran-122 force-pushed the issue-8410-stabilize-service-instance-id branch from 439332e to 4fe6d42 Compare September 9, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize service.instance.id on resource

2 participants