To validate Base16 strings with null and odd length handling - #8786
To validate Base16 strings with null and odd length handling#8786NithinU2802 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8786 +/- ##
============================================
+ Coverage 91.26% 91.30% +0.03%
- Complexity 10503 10508 +5
============================================
Files 1007 1007
Lines 28373 28375 +2
Branches 3586 3586
============================================
+ Hits 25896 25909 +13
+ Misses 1685 1673 -12
- Partials 792 793 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
What problem does this solve? Did you actually encounter an issue that led to this? See https://github.com/open-telemetry/opentelemetry-java/blob/main/docs/knowledge/api-design.md#null-guards for repo philosophy on null checks given our use of nullaway. |
Yes, the null guard is already present, and I also added a check for an empty CharSequence value. I initially raised this PR with the goal of improving Base16String validation mainly with odd length strings. However, I later noticed that with the padding, the value is handled on the other side. The method |
|
|
||
| /** Returns whether the {@link CharSequence} is a valid hex string. */ | ||
| public static boolean isValidBase16String(CharSequence value) { | ||
| if (value == null || value.length() == 0) { |
There was a problem hiding this comment.
Realized this is an internal method so no null check is required. As described here, we only add null guards at public API entry points.
Also, is a CharSequence with length 0 an invalid base16 string? I don't think so, so I think we should close this PR.
2 participants
This PR fixes an issue in
OtelEncodingUtils.isValidBase16String(), which currently accepts strings with odd lengths even though the encoding utilities in this class operate on byte pairs, where each byte must be represented by exactly two hexadecimal characters.The fix ensures that the method
rejects odd length Base16 strings and properly handles null and empty CharSequence inputs.Regression tests have also been added to cover these cases and verify the expected validation behavior.