Issue 6459 otel assertions no extends - #8788
Open
Rajkaran-122 wants to merge 1 commit into
Open
Conversation
…pen-telemetry#6459) Add Javadoc documentation explaining that OpenTelemetryAssertions extends AssertJ's Assertions class, which brings in generic assertThat(T) and causes ambiguity when using static imports alongside other assertion libraries like Truth. Document the workaround: use non-static import and reference methods explicitly via OpenTelemetryAssertions.assertThat(...). Add test demonstrating the workaround to ensure it compiles and works correctly.
Rajkaran-122
force-pushed
the
issue-6459-otel-assertions-no-extends
branch
from
September 9, 2026 20:04
3ef7b7a to
bd18504
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8788 +/- ##
============================================
- Coverage 91.48% 91.30% -0.19%
- Complexity 10467 10518 +51
============================================
Files 1021 1007 -14
Lines 27694 28386 +692
Branches 3247 3591 +344
============================================
+ Hits 25337 25917 +580
- Misses 1615 1675 +60
- Partials 742 794 +52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@jkwatson @jack-berg sir PTAL #8788 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6459
This PR documents the existing workaround for the ambiguity caused when
OpenTelemetryAssertionsis statically imported alongside other assertion libraries such as Truth.OpenTelemetryAssertionscurrently extends AssertJ'sAssertions, which can introduce an ambiguousassertThat(...)reference when multiple assertion libraries are used together.Changes
Added Javadoc to
OpenTelemetryAssertionsexplaining the assertion ambiguity.Documented the recommended workaround:
OpenTelemetryAssertions.OpenTelemetryAssertions.assertThat(...)explicitly.Added a test demonstrating that the non-static import workaround works as expected.
Compatibility
This approach intentionally avoids removing
extends Assertions, which would be an API-breaking change for existing users.The change therefore provides documentation and an example of the existing non-breaking workaround without modifying the public API.
Validation
TraceAssertionsTestpasses.#6459work.Related
Fixes #6459