[opentelemetry-util-genai] Decouple stream wrappers from GenAIInvocation with typing protocols - #745
Merged
lmolkova merged 3 commits intoSep 21, 2026
Conversation
…ion with typing protocols
Pull request dashboard statusMerged · refreshed 2026-09-21 04:45 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Protocol-only invocation paths lack sync and async regression tests.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Decouples stream wrappers from GenAIInvocation using structural protocols while preserving streaming timing and markers.
Changes:
- Adds timing and streaming invocation protocols.
- Updates sync and async wrappers to use protocol-based typing.
- Conditionally sets the stream marker for compatible invocations.
| File | Description |
|---|---|
util/opentelemetry-util-genai/src/opentelemetry/util/genai/stream.py |
Introduces protocols and updates wrapper invocation handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eternalcuriouslearner
approved these changes
Sep 20, 2026
github-project-automation
Bot
moved this to Done
in GenAI Semantic Conventions and Instrumentation libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Replaces
GenAIInvocationtyping dependencies instream.pywith_StreamTimingInvocationand_StreamingInvocationprotocols.Why?
Decouples public stream wrappers from internal
_invocation.pyimplementation details and helps prepare for codegen (#702).