Skip to content

fix(jaeger): accept URL-encoded uber-trace-id header on extract #5793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
herin049 merged 4 commits into from
Oct 26, 2026
Merged

fix(jaeger): accept URL-encoded uber-trace-id header on extract #5793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb09935
fix(jaeger): accept URL-encoded uber-trace-id on extract
LemonCondor Oct 25, 2026
7596bfd
Rename changelog fragment to PR number
LemonCondor Oct 25, 2026
f4d2a5c
Merge branch 'main' into fix/jaeger-encoded-trace-id
herin049 Oct 26, 2026
dabcb12
Merge branch 'main' into fix/jaeger-encoded-trace-id
herin049 Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5793.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`opentelemetry-propagator-jaeger`: Accept a URL-encoded `uber-trace-id` header on extract
5 changes: 5 additions & 0 deletions propagator/opentelemetry-propagator-jaeger/src/opentelemetry/propagators/jaeger/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,11 @@ def _parse_trace_id_header(
if header is None:
return invalid_header_result

# some Jaeger clients URL-encode the header value, including the ":"
# delimiter, so decode it when no plain delimiter can be found
if ":" not in header:
Comment thread
herin049 marked this conversation as resolved.
header = urllib.parse.unquote(header)

fields = header.split(":")
if len(fields) != 4:
return invalid_header_result
Expand Down
8 changes: 8 additions & 0 deletions propagator/opentelemetry-propagator-jaeger/tests/test_jaeger_propagator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ def test_extract_valid_span(self):
self.assertEqual(span_context.trace_id, self.trace_id)
self.assertEqual(span_context.span_id, self.span_id)

def test_extract_url_encoded_span(self):
# some Jaeger clients URL-encode the ':' delimiter of uber-trace-id
old_carrier = {FORMAT.TRACE_ID_KEY: self.serialized_uber_trace_id.replace(":", "%3A")}
ctx = FORMAT.extract(old_carrier)
span_context = trace_api.get_current_span(ctx).get_span_context()
self.assertEqual(span_context.trace_id, self.trace_id)
self.assertEqual(span_context.span_id, self.span_id)

def test_missing_carrier(self):
old_carrier = {}
ctx = FORMAT.extract(old_carrier)
Expand Down
Loading