Skip to content

opentelemetry-configuration: split Parse/Create per the configuration spec - #5829

Open
herin049 wants to merge 3 commits into
open-telemetry:mainfrom
herin049:fix/configuration-create-sdk
Open

herin049 wants to merge 3 commits into
open-telemetry:mainfrom
herin049:fix/configuration-create-sdk

Conversation

@herin049

Copy link
Copy Markdown
Contributor

Description

Aligns opentelemetry-configuration with the declarative configuration spec's Parse and Create operations.

  • load_config_file -> load_config: accepts a path or a text stream (with file_format).
  • New create_sdk(config) -> SdkComponents: stateless; returns the tracer/meter/logger providers, propagator, and resource. configure_sdk now creates first and only then installs globals.
  • Omitted provider sections yield no-op providers; disabled: true keeps the configured propagator. Providers already created are shut down if creation fails.
  • One-of schema types (e.g. Sampler) reject zero or multiple choices at construction.
  • SDK: MeterProvider.add_metric_reader now sets the reader's meter provider, and readers added at runtime are included in force_flush/shutdown.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • I am a human and not a bot
  • I have run tox -e precommit
  • I have run tox -e typecheck
  • I have run the relevant tests and linting tox environments
  • This requires the following PR in contrib:

@herin049
herin049 requested a review from a team as a code owner October 26, 2026 03:41
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-10-26 03:52 UTC

Review the latest changes.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@herin049 herin049 added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Oct 26, 2026
@herin049
herin049 force-pushed the fix/configuration-create-sdk branch from c9bda01 to 93ecc00 Compare October 26, 2026 03:45
@herin049
herin049 force-pushed the fix/configuration-create-sdk branch from 93ecc00 to dde4865 Compare October 26, 2026 03:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant