Repository navigation
[Fix #1776] Make DefaultResourceLoader easier to customize - #1777
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
URI rewriting introduces null-host failures and changes encoded path segments.
2 open issues
What changed in this PR
Makes DefaultResourceLoader easier to customize through protected resource-creation and URI-handling hooks.
Changes:
- Exposes file and HTTP resource creation to subclasses.
- Moves GitHub URL rewriting from
HttpResourceinto the loader. - Converts the GitHub helper to use
URI.
| File | Description |
|---|---|
| impl/core/src/main/java/org/openworkflow/sdk/impl/resources/HttpResource.java | Uses the supplied URL without rewriting it. |
| impl/core/src/main/java/org/openworkflow/sdk/impl/resources/GitHubHelper.java | Rewrites GitHub addresses using URI components. |
| impl/core/src/main/java/org/openworkflow/sdk/impl/resources/DefaultResourceLoader.java | Adds protected customization hooks. |
Review effort: Balanced
2 tasks done
…ier to customize fileResource and httpResource are now protected. Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1776
fileResource and httpResource are now protected.