Repository navigation
Only rescan the subtree that changed - #27
Open
robbiefish wants to merge 2 commits into
Open
robbiefish wants to merge 2 commits into
robbiefish wants to merge 2 commits into
Conversation
Rescanning from the root while openDAQ holds the changed component's lock deadlocks against anything holding another device's lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rescanning from the root while openDAQ holds the changed component's lock deadlocks against anything holding another device's lock.
Two threads deadlock on two different component locks:
Thread A (the caller)
connect signal to input port
-> function block's onConnected takes the function block's lock
-> adds a nested component
-> ComponentAdded core event
-> LT streaming server handler calls rescan()
-> rescan walks the whole instance from the root
-> blocks waiting for the device's lock
Thread B (the device acquisition thread)
holds the device's lock while sending a packet
-> packet is delivered to the function block (SameThread notification)
-> function block's onPacketReceived wants the function block's lock
-> blocks
A holds the function block lock and wants the device lock. B holds the device lock and wants the function block lock.
This PR scopes the core event handlers so they only look at what the event actually changed, instead of rescanning from the root.