Repository navigation
Move generic client TimestampMode/SamplingInterval to device defaults - #41
Merged
viacheslauK merged 4 commits intoOct 1, 2026
Merged
Conversation
…mestampMode unless set explicitly
…onitoredItems unless set explicitly
…m add-device config to device-only properties
… of config, initialized from device defaults
viacheslauK
changed the title
JakaMohorko
approved these changes
Sep 30, 2026
JakaMohorko
reviewed
Sep 30, 2026
| status and reconfigures the signals if the data type changed: | ||
| | Property | Type | Default | In config | Applied | | ||
| |---|---|---|---|---| | ||
| | `LocalId` | String | `""` | yes | at creation only | |
Contributor
There was a problem hiding this comment.
I can't quite tell from this PR, but is the LocalID required here? It should be optional and generated for the monitored item FB if left empty.
Contributor
Author
There was a problem hiding this comment.
You can leave it empty, it is not required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The device now holds only defaults for new blocks:
DefaultTimestampModeandDefaultSamplingInterval. EachMonitoredItemhas its ownTimestampModeandSamplingIntervalproperties, which start from those defaults. None of these properties is part of a config. They exist only as properties after the object is created.Changes
Device:
TimestampModeis replaced byDefaultTimestampModeandDefaultSamplingIntervalis added. An invalid interval falls back to 100 ms. The config parameter andcreateDefaultConfig()are removed.Module: the add-device default config no longer contains device properties.
MonitoredItem FB:
SamplingIntervalis removed from the type's default config.TimestampModeandSamplingIntervalare added as FB properties, initialized from the device defaults.setDomainSource()is removed.Tests / USAGE.md: updated for the new model. New tests cover inheriting the defaults and ignoring these properties when they are passed in a config.
Notes