Skip to content

Remove the shipped dead code: legacy MATLAB generator and _depr StructConverter #170

Description

@ehennestad

Two pieces of code ship in the toolbox that are known not to work or not to be used:

  1. The legacy MATLAB generator, code/+openminds/+internal/+generator/ (SchemaTranslator.m, +abstract/ClassWriter.m, update.m, generateSchemaClasses.m, createMixedTypeSetClass.m, downloadSchemas.m; 1561 lines). Its own README says it is "currently not up to date with the python build pipeline, and might not work as intended. Kept around in hopes that it will be updated someday." update.m calls openminds.internal.downloadSchemas and openminds.internal.generateSchemaClasses, which no longer exist. The real generator is Python, on the pipeline branch. The folder is excluded from coverage via tools/.coverageignore.
  2. code/+openminds/+internal/+serializer/_depr/StructConverter.m (308 lines), superseded by the Transformer-based serializer.

Both are inside the packaged toolbox, appear in Add-On Explorer installs, and turn up in search and in the Code Analyzer's SARIF output. Git history keeps them if they are ever wanted.

Proposal: delete both. If a MATLAB-native generator is still a goal, an issue saying so is a better placeholder than 1.9k lines that cannot run.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions