pass data object as parameter in set_power_limit methode, review - #3856
Merged
Conversation
LKuemmel
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Passes consumer limit metadata through the power-limit control path.
Changes:
- Adds
SetLimitDatacontaining the configured maximum power. - Passes limit metadata to configurable consumer modules.
- Updates hierarchy documentation to include consumers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/modules/consumers/generic/mqtt/consumer.py |
Accepts limit metadata in the MQTT callback. |
packages/modules/common/configurable_consumer.py |
Defines and forwards SetLimitData. |
packages/control/process.py |
Builds limit metadata and updates timestamp handling. |
packages/control/counter_all/hierarchy.py |
Clarifies consumer support in documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LKuemmel
force-pushed
the
feature_consumer
branch
2 times, most recently
from
August 28, 2026 13:13
ec21410 to
b360705
Compare
LKuemmel
force-pushed
the
feature_consumer
branch
from
September 7, 2026 13:37
c8dce9b to
a48f53c
Compare
LKuemmel
force-pushed
the
consumer_dev
branch
from
September 8, 2026 07:18
702f55d to
1d2508e
Compare
LKuemmel
force-pushed
the
consumer_dev
branch
from
September 8, 2026 07:28
1d2508e to
3c39c15
Compare
LKuemmel
added a commit
to benderl/core
that referenced
this pull request
Sep 8, 2026
…enWB#3856) * improve * review: update comments * flake8 * fix rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.