fix: make runCommand maxBuffer explicit - #747
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Edo771977
pushed a commit
to Edo771977/codex-plugin-cc
that referenced
this pull request
Sep 17, 2026
Upstream PR openai#747 (sylvesterkaczmarek), two conflicts resolved. runCommand() passed options.maxBuffer straight through, so an unset value left Node's 1 MiB spawnSync default in place and a large `git diff` came back truncated with ENOBUFS. It now defaults to an explicit 256 MiB, and an explicit override still wins. Conflicts: both are adjacency, not disagreement. In process.mjs the fork had added `timeout`/`killSignal` on the lines around `maxBuffer`; the resolved call keeps all three. In tests/process.test.mjs the PR's import line is dropped (the fork's import block already names runCommand and terminateProcessTree) and its two tests are appended. Verified: node --check on both files; tests/process.test.mjs 13/13. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UXfvnjSC72HsM6EEPVt2Tg
Edo771977
pushed a commit
to Edo771977/codex-plugin-cc
that referenced
this pull request
Sep 17, 2026
Adds openai#731, openai#737, openai#747 and openai#763 to "Differences From Upstream", and notes in Requirements that Node no longer has to be on the system PATH now that the hooks go through scripts/run-node.sh (including CODEX_COMPANION_NODE for pinning one). Verified: full npm test 254/254. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UXfvnjSC72HsM6EEPVt2Tg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thanks for the detailed report in #744. This makes the intended buffering behaviour explicit instead of relying on an
undefinedoption overriding Node's 1 MiBspawnSyncdefault.runCommandmaxBuffervalues used by measurement gatesValidation
npm test(93 passed)node --test tests/process.test.mjs(4 passed)npm run check-versiongit diff --checkFixes #744